New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: put RemoteCertVerifier upstream from the caching and coalescing layers #28358
Conversation
Release Notes Persisted
|
I was unable to backport this PR to "12-x-y" cleanly; |
I was unable to backport this PR to "11-x-y" cleanly; |
I have automatically backported this PR to "13-x-y", please check out #28433 |
Description of Change
This fixes #28313.
Before this change, the RemoteCertVerifier would receive several concurrent
requests to verify the same domain, and the 2nd one to return would cause a
crash. I'm not totally sure what the exact cause of the crash was, but putting
the RemoteCertVerifier upstream from the coalescing and caching layers means
that only one verification request gets sent to the main process, and by doing
so fixes the crash.
Checklist
npm test
passesRelease Notes
Notes: Fixed a network process crash that could happen when using
setCertificateVerifyProc
with many concurrent verification requests.