Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put RemoteCertVerifier upstream from the caching and coalescing layers #28358

Merged
merged 1 commit into from Mar 29, 2021

Conversation

nornagon
Copy link
Member

Description of Change

This fixes #28313.

Before this change, the RemoteCertVerifier would receive several concurrent
requests to verify the same domain, and the 2nd one to return would cause a
crash. I'm not totally sure what the exact cause of the crash was, but putting
the RemoteCertVerifier upstream from the coalescing and caching layers means
that only one verification request gets sent to the main process, and by doing
so fixes the crash.

Checklist

Release Notes

Notes: Fixed a network process crash that could happen when using setCertificateVerifyProc with many concurrent verification requests.

@nornagon nornagon requested a review from a team as a code owner March 23, 2021 18:30
@nornagon nornagon added semver/patch backwards-compatible bug fixes target/11-x-y labels Mar 23, 2021
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Mar 23, 2021
@nornagon nornagon merged commit 9a7cfc4 into master Mar 29, 2021
@nornagon nornagon deleted the fix-remote-cert-verifier branch March 29, 2021 22:35
@release-clerk
Copy link

release-clerk bot commented Mar 29, 2021

Release Notes Persisted

Fixed a network process crash that could happen when using setCertificateVerifyProc with many concurrent verification requests.

@trop
Copy link
Contributor

trop bot commented Mar 29, 2021

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Mar 29, 2021

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Mar 29, 2021

I have automatically backported this PR to "13-x-y", please check out #28433

@trop
Copy link
Contributor

trop bot commented Mar 31, 2021

@nornagon has manually backported this PR to "12-x-y", please check out #28465

@trop
Copy link
Contributor

trop bot commented Mar 31, 2021

@nornagon has manually backported this PR to "11-x-y", please check out #28470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
3 participants