This repository has been archived by the owner on May 28, 2021. It is now read-only.
Description change #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (#28709) * chore: update ts parser for description comment fixes * docs: strongly type the getUserDefault API * spec: add getUserMedia type assertions to smoke run
…28681) When creating a widget on linux the bounds are restricted to the screen size, when calling SetSize / SetBounds they are not. This fixes this initialization issue by calling SetBounds after widget creation. Noticed this issue while running linux tests on xvfb with a screen size smaller than the default electron window size (resulted in a failed test).
Bumps [ssri](https://github.com/npm/ssri) from 6.0.1 to 6.0.2. - [Release notes](https://github.com/npm/ssri/releases) - [Changelog](https://github.com/npm/ssri/blob/v6.0.2/CHANGELOG.md) - [Commits](npm/ssri@v6.0.1...v6.0.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* build: disable pseudolocales in Electron * Update build/args/all.gn Co-authored-by: Jeremy Rose <jeremya@chromium.org> Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add WebFrameMain.visibilityState * docs: mention other page visibility APIs * test: delay visibilityState check after hiding * test: add waitForTrue to avoid flaky visibilityState test * refactor: waitForTrue -> waitUntil
…28769) * chore: remove CanUseCustomSiteInstance * chore: remove unused ShouldOverrideSiteInstanceForNavigation * chore: remove CreateRelatedSiteInstance * chore: remove BrowsingInstance::CreateSiteInstanceForURL * chore: remove NavigationState::REUSE_SITE_INSTANCE * chore: remove accidentally duplicated code post-patch-clean * chore: reword patch description for new feature-set * chore: remove ShouldForceNewSiteInstance and all its unused helpers
* refactor: use rfh instead of process id in permission manager * fix build * Update electron_permission_manager.cc * swap for smaller diff
This reverts commit a1386dc.
Bumps [ws](https://github.com/websockets/ws) from 6.2.1 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.1...7.4.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: peteness <hello@peteness.org>
* feat: emit resize edge with will-resize event fix: wparam type fix: private member usage on mac docs: will-resize event edge option refactor: 'info' -> 'details' for better type gen * Update docs/api/browser-window.md Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com> * Update docs/api/browser-window.md Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* improve progress bar fiddle * add comments to code snippet * edits to progress-bar tutorial * remove versions and nodeIntegration * limit line length to 100 * implement standard linter suggestions * add indeterminate and clear timers * update to have reader replace all of main.js * remove extra button * loop the progress bar * add logic to show reset state briefly * Update docs/tutorial/progress-bar.md Co-authored-by: Erick Zhao <erick@hotmail.ca> * chore: fix lint Co-authored-by: Cheng Zhao <github@zcbenz.com> Co-authored-by: Erick Zhao <erick@hotmail.ca>
…nslated apps running on Windows ARM (#29168) * feat: add new runningUnderARM64Translation property to detect x64 translated apps running on Windows ARM * docs: add documentation for the new runningUnderARM64Translation property * refactor: clean up `IsRunningUnderARM64Translation` Windows implementation * Return false if IsWow64Process2 doesn't exist * Emit deprecation warning in runningUnderRosettaTranslation
Electron already seems to support `cygwin`, so `msys` is a natural addition. This is the only required change as far as I can see on my local development environment, as otherwise the build scripts don't realize that msys = windows. Notes: none Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
* fix: correctly handle shifted char in accelerator * test: use actual accelerator of NSMenuItem * chore: simplify KeyboardCodeFromStr * chore: GetAcceleratorTextAt is testing only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Checklist
npm testpassesRelease Notes
Notes: