-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Renderer spellcheck API does not work on Windows #28404
Comments
This comment might be related: |
Confirmed works on Linux. Tested with Electron 12.0.2 on Ubuntu 20.10. Electron fiddle test: https://gist.github.com/ckerr/91b84f22d5beeef1506174b495720dd7 |
This is because by default the spellchecker only automatically detects language on macOS - see: Lines 691 to 699 in 45c4dd5
If you add |
I have tried adding An observation is that Electron correctly spellchecks the textarea with English, without having to set the language, but the API still returns |
@codebytere Can you verify/repro this on Windows? |
@ckerr Any chance we can have this re-opened? |
Preflight Checklist
Electron Version
12.0.2
What operating system are you using?
Windows
Operating System Version
Windows 10 1909
What arch are you using?
x64
Last Known Working Electron version
No response
Expected Behavior
renderer.js
Expected: Console log repeatedly print "true"
Actual Behavior
Actual: Console log repeatedly prints "false"
Testcase Gist URL
(edit ckerr): https://gist.github.com/ckerr/91b84f22d5beeef1506174b495720dd7
Concerning the API released in #25060
@zcbenz Noticed you were working on spellcheck related tests. It seems that the tests for this API don't run on Windows so it wasn't caught:
electron/spec-main/spellchecker-spec.ts
Line 84 in f08b67f
This seems to work on Linux for me, but not on Windows.
The text was updated successfully, but these errors were encountered: