-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add clarification for Visual Zoom behavior #28860
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Merging as CI failures are unrelated to doc change. |
Congrats on merging your first pull request! 🎉🎉🎉 |
No Release Notes |
I was unable to backport this PR to "12-x-y" cleanly; |
I was unable to backport this PR to "11-x-y" cleanly; |
I was unable to backport this PR to "13-x-y" cleanly; |
* Add clarification for visual zoom documentation
@georgexu99 has manually backported this PR to "13-x-y", please check out #29764 |
Description of Change
Electron doesn't seem to have documentation about how to disable zoom shortcuts. A lot of online resources point towards the
setVisualZoomLevelLimits
function, but it's not obvious that this function ONLY applies to pinch-to-zoom behavior.This PR adds a note of clarification and suggestions for how to address the zoom shortcuts.
Checklist
npm test
passesRelease Notes
Notes: no notes.