Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add clarification for Visual Zoom behavior #28860

Merged
merged 4 commits into from
Apr 28, 2021

Conversation

michaelkozakovsc
Copy link
Contributor

@michaelkozakovsc michaelkozakovsc commented Apr 27, 2021

Description of Change

Electron doesn't seem to have documentation about how to disable zoom shortcuts. A lot of online resources point towards the setVisualZoomLevelLimits function, but it's not obvious that this function ONLY applies to pinch-to-zoom behavior.

This PR adds a note of clarification and suggestions for how to address the zoom shortcuts.

Checklist

Release Notes

Notes: no notes.

@welcome
Copy link

welcome bot commented Apr 27, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 27, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 28, 2021
@jkleinsc
Copy link
Contributor

Merging as CI failures are unrelated to doc change.

@jkleinsc jkleinsc merged commit c37c9ad into electron:master Apr 28, 2021
@welcome
Copy link

welcome bot commented Apr 28, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Apr 28, 2021

No Release Notes

@trop
Copy link
Contributor

trop bot commented Apr 28, 2021

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 28, 2021

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 28, 2021

I was unable to backport this PR to "13-x-y" cleanly;
you will need to perform this backport manually.

georgexu99 pushed a commit to georgexu99/electron that referenced this pull request Jun 17, 2021
* Add clarification for visual zoom documentation
@trop
Copy link
Contributor

trop bot commented Jun 17, 2021

@georgexu99 has manually backported this PR to "13-x-y", please check out #29764

VerteDinde pushed a commit that referenced this pull request Jun 18, 2021
* Add clarification for visual zoom documentation

Co-authored-by: Michael Kozakov <michael.kozakov@snapchat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants