-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: link to BrowserView
from webview
page
#28942
Conversation
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
BrowserView
from webview
pageBrowserView
from webview
page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like lint is failing:
File Location: /home/builduser/project/src/electron/docs/api/webview-tag.md
Broken links: browser-view
Parsed through 204 files within docs directory and its 69 subdirectories.
Found 1 broken relative links.
Thanks @codebytere! I think I missed the right link format. Pushed a fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hamstu! looks good ✨
Congrats on merging your first pull request! 🎉🎉🎉 |
No Release Notes |
I have automatically backported this PR to "13-x-y", please check out #29008 |
I have automatically backported this PR to "12-x-y", please check out #29009 |
I have automatically backported this PR to "11-x-y", please check out #29010 |
Description of Change
Make it easier to jump to the docs page on BrowserView. ✨
Checklist
npm test
passesRelease Notes
Notes: none.