refactor: remove unnecessary setupDialogProperties #28982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
May 4, 2021
|
@miniak is there a reason we shouldn't backport this? I think it should be fine 🤔 |
|
@codebytere We can, I just thought we don’t backport refactorings |
miniak
force-pushed
the
miniak/cleanup-dialog
branch
from
417bd1f
to
89d6014
Compare
|
@codebytere conflict after merging #28980 resolved |
nornagon
approved these changes
May 4, 2021
|
agree with @miniak, no need to backport this as it doesn't fix anything. |
zcbenz
approved these changes
May 5, 2021
|
No Release Notes |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Just call
setupOpenDialogProperties/setupSaveDialogPropertiesdirectlyChecklist
npm testpassesRelease Notes
Notes: no-notes