Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 'focus-change' does not need guestInstanceId #29001

Merged
merged 2 commits into from
May 5, 2021
Merged

refactor: 'focus-change' does not need guestInstanceId #29001

merged 2 commits into from
May 5, 2021

Conversation

miniak
Copy link
Contributor

@miniak miniak commented May 4, 2021

Description of Change

The guestInstanceId is not used in the focus-change handler. It is also the same as webContents ID that we already know.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 4, 2021
@miniak miniak force-pushed the miniak/webview-focus-change branch from cf6469e to 6824d62 Compare May 4, 2021 21:48
@miniak miniak self-assigned this May 4, 2021
@miniak miniak added semver/patch backwards-compatible bug fixes no-backport labels May 4, 2021
nornagon
nornagon reviewed May 4, 2021
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is focus-change an internal-only event? if so we should probably prefix it like -focus-change

@miniak
Copy link
Contributor Author

miniak commented May 4, 2021 •
edited

@nornagon yes, it is internal. I've added the prefix.

@miniak miniak requested a review from nornagon May 5, 2021 05:08
@MarshallOfSound MarshallOfSound merged commit 2086e19 into master May 5, 2021
@release-clerk
Copy link

release-clerk bot commented May 5, 2021

No Release Notes

@MarshallOfSound MarshallOfSound deleted the miniak/webview-focus-change branch May 5, 2021 18:37
@Mario-Kart-Felix Mario-Kart-Felix mentioned this pull request May 17, 2021
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@nornagon nornagon nornagon approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees

@miniak miniak

Labels
new-pr 🌱 PR opened in the last 24 hours no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miniak @ckerr @nornagon @MarshallOfSound