Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly handle Alt+Key shortcuts #29328

Merged
merged 1 commit into from Jun 1, 2021
Merged

fix: correctly handle Alt+Key shortcuts #29328

merged 1 commit into from Jun 1, 2021

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented May 26, 2021

Description of Change

Fix pressing keys like Alt+Shift wrongly getting captured for menu shortcuts, close #28088.

Release Notes

Notes: Fix pressing Alt+Shift and Alt+Ctrl toggling menu bar on KDE.

@zcbenz zcbenz added semver/patch backwards-compatible bug fixes target/12-x-y labels May 26, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 26, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 27, 2021
@zcbenz zcbenz merged commit d74ad51 into master Jun 1, 2021
@release-clerk
Copy link

release-clerk bot commented Jun 1, 2021

Release Notes Persisted

Fix pressing Alt+Shift and Alt+Ctrl toggling menu bar on KDE.

@zcbenz zcbenz deleted the fix-menu-bar-quirks-3 branch June 1, 2021 01:48
@trop
Copy link
Contributor

trop bot commented Jun 1, 2021

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

This was referenced Jun 1, 2021
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jun 1, 2021

I have automatically backported this PR to "13-x-y", please check out #29443

@trop trop bot removed the target/13-x-y label Jun 1, 2021
@trop
Copy link
Contributor

trop bot commented Jun 1, 2021

I have automatically backported this PR to "14-x-y", please check out #29444

@zcbenz zcbenz mentioned this pull request Jun 1, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Jun 1, 2021

@zcbenz has manually backported this PR to "12-x-y", please check out #29445

@xvenge00 xvenge00 mentioned this pull request Jun 12, 2021
Closed
@RaisinTen RaisinTen mentioned this pull request Feb 25, 2022
Closed
@RaisinTen RaisinTen mentioned this pull request Aug 10, 2022
Closed
3 tasks
@theforbiddenpool theforbiddenpool mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
2 participants
@zcbenz @codebytere