Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos in comments #29401

Merged
merged 1 commit into from Jun 1, 2021
Merged

chore: fix typos in comments #29401

merged 1 commit into from Jun 1, 2021

Conversation

dsanders11
Copy link
Member

Description of Change

Back with another installment.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 28, 2021
@MarshallOfSound
Copy link
Member

I'm all for fixing these things I just wanted to highlight quickly that every CI run costs money, every backport costs money. If possible can you try do all of these typo style fixes in a single PR rather that spreading them over multiple, otherwise it consumes a CI infrastructure for no real reason.

@dsanders11
Copy link
Member Author

@MarshallOfSound, understood. Wasn't intentionally spreading them out into separate PRs, just happened to be when they were discovered. I'll try to consolidate them more, but it's often easiest to fire it off when they're found, otherwise it gets lost, as I'm usually pursuing something else when the typo is spotted.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 1, 2021
@zcbenz zcbenz merged commit 038359a into electron:master Jun 1, 2021
@release-clerk
Copy link

release-clerk bot commented Jun 1, 2021

No Release Notes

@MarshallOfSound
Copy link
Member

/trop run backport-to 14-x-y

@trop
Copy link
Contributor

trop bot commented Jun 3, 2021

The backport process for this PR has been manually initiated - sending your PR to 14-x-y!

@trop trop bot mentioned this pull request Jun 3, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Jun 3, 2021

I have automatically backported this PR to "14-x-y", please check out #29519

@dsanders11 dsanders11 deleted the fix-comment-typos-2 branch June 3, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsanders11 @MarshallOfSound @zcbenz