Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos in comments #29401

Merged
merged 1 commit into from Jun 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion shell/browser/api/electron_api_web_request.cc
Expand Up @@ -387,7 +387,7 @@ void WebRequest::SetListener(Event event,
std::set<std::string> filter_patterns;
gin::Dictionary dict(args->isolate());
if (args->GetNext(&arg) && !arg->IsFunction()) {
// Note that gin treats Function as Dictionary when doing convertions, so we
// Note that gin treats Function as Dictionary when doing conversions, so we
// have to explicitly check if the argument is Function before trying to
// convert it to Dictionary.
if (gin::ConvertFromV8(args->isolate(), arg, &dict)) {
Expand Down
2 changes: 1 addition & 1 deletion shell/browser/ui/accelerator_util.h
Expand Up @@ -23,7 +23,7 @@ typedef std::map<ui::Accelerator, MenuItem> AcceleratorTable;
bool StringToAccelerator(const std::string& description,
ui::Accelerator* accelerator);

// Generate a table that contains memu model's accelerators and command ids.
// Generate a table that contains menu model's accelerators and command ids.
void GenerateAcceleratorTable(AcceleratorTable* table,
electron::ElectronMenuModel* model);

Expand Down
4 changes: 2 additions & 2 deletions shell/common/gin_helper/callback.h
Expand Up @@ -14,7 +14,7 @@
#include "shell/common/gin_helper/function_template.h"
#include "shell/common/gin_helper/locker.h"
#include "shell/common/gin_helper/microtasks_scope.h"
// Implements safe convertions between JS functions and base::RepeatingCallback.
// Implements safe conversions between JS functions and base::RepeatingCallback.

namespace gin_helper {

Expand Down Expand Up @@ -110,7 +110,7 @@ struct V8FunctionInvoker<ReturnType(ArgTypes...)> {
}
};

// Helper to pass a C++ funtion to JavaScript.
// Helper to pass a C++ function to JavaScript.
using Translater = base::RepeatingCallback<void(gin::Arguments* args)>;
v8::Local<v8::Value> CreateFunctionFromTranslater(v8::Isolate* isolate,
const Translater& translater,
Expand Down
2 changes: 1 addition & 1 deletion shell/common/gin_helper/function_template.h
Expand Up @@ -96,7 +96,7 @@ bool GetNextArgument(gin::Arguments* args,
}

// Support base::Optional as output, which would be empty and do not throw error
// when convertion to T fails.
// when conversion to T fails.
template <typename T>
bool GetNextArgument(gin::Arguments* args,
int create_flags,
Expand Down