-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: windows notifications not closing #29557
Comments
I think the expected behavior is that the notification stays in the notification center until it's dismissed by the user there, or dismissed manually by But the problem is that |
Looking at the spec: https://notifications.spec.whatwg.org/#lifetime-and-ui-integrations
It used to just treat it as a non-persistent notification, but now it looks like it has aspects from both. It keeps it in the notification center but also is still firing the close handler after the popup disappears and is ignoring Does electron even have official support for persistent notifications? |
Any news on this? Notifications should really conform to some specs
I can confirm this is still broken on v16.0.8 |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue. |
Preflight Checklist
Electron Version
12^
Operating System Version
Windows 10 v19042
What arch are you using?
x64
Last Known Working Electron version
11 downwards
Expected Behavior (Electron 11 and older)
notifications would close after timeout, not appearing the windows 10 notification center. (and thus not duplicating)
Actual Behavior (Electron 12 and newer)
After the notification timeout - it moves to the notification center without closing and also can't be closed programmatically
(notification.close doesn't do anything IF it has already timeout and moved to notification center)
which can result in a spam of notifications in notification center
Testcase Gist URL
https://gist.github.com/a1c1ac4c057370540be18e0b5aeefb89
Additional Information
I found no documentation or breaking change that indicate any modifications in notification API
reported at th-ch/youtube-music#312
tested by me on multiple versions of electron 11, 12 and 13 - including latest releases
if this doesn't get directly fixed - there should atleast be an option "close on timeout" that allows using that functionality and avoid spamming the notification center
The text was updated successfully, but these errors were encountered: