Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improper wrapping of fs.promises.readFile #29577

Merged
merged 2 commits into from Jun 8, 2021
Merged

fix: improper wrapping of fs.promises.readFile #29577

merged 2 commits into from Jun 8, 2021

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 7, 2021

Backport of #29528

See that PR for details.

Notes: Fixd an issue where fs.promises.readFile would improperly error when passing a FileHandle to the path argument.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 7, 2021
@trop trop bot requested a review from codebytere June 7, 2021 19:20
@trop trop bot mentioned this pull request Jun 7, 2021
Merged
4 tasks
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 7, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 7, 2021
@codebytere codebytere merged commit e3a613d into 14-x-y Jun 8, 2021
@codebytere codebytere deleted the trop/14-x-y-bp-fix-improper-wrapping-of-fs-promises-readfile-1623093594872 branch June 8, 2021 08:31
@release-clerk
Copy link

release-clerk bot commented Jun 8, 2021

Release Notes Persisted

Fixd an issue where fs.promises.readFile would improperly error when passing a FileHandle to the path argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@codebytere