-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improper wrapping of fs.promises.readFile #29528
Conversation
d5eb69e
to
b98686b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Test? 😉
6afefdb
to
1b0fe88
Compare
Release Notes Persisted
|
I have automatically backported this PR to "12-x-y", please check out #29575 |
I have automatically backported this PR to "13-x-y", please check out #29576 |
I have automatically backported this PR to "14-x-y", please check out #29577 |
Description of Change
Fixes an issue where
fs.promises.readFile
would improperly error when running e.g:with:
becuase our fs wrapper simply used
util.promisify
on the asar-ified version offs.readFile
instead of calling into Node.js' actual version, which is implemented slightly differently.Checklist
npm test
passesRelease Notes
Notes: Fixd an issue where
fs.promises.readFile
would improperly error when passing aFileHandle
to thepath
argument.