Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix setWindowOpenHandler invocation in window.open example #29727

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 16, 2021

Backport of #29551

See that PR for details.

Notes: Fixed invocation of webContents.setWindowOpenHandler in window.open example.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 16, 2021
@trop trop bot added 14-x-y backport This is a backport PR semver/none labels Jun 16, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 16, 2021
@MarshallOfSound MarshallOfSound merged commit 1789cfa into 14-x-y Jun 16, 2021
@MarshallOfSound MarshallOfSound deleted the trop/14-x-y-bp-docs-fix-setwindowopenhandler-invocation-in-window-open-example-1623827797815 branch June 16, 2021 17:12
@release-clerk
Copy link

release-clerk bot commented Jun 16, 2021

Release Notes Persisted

Fixed invocation of webContents.setWindowOpenHandler in window.open example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants