Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix setWindowOpenHandler invocation in window.open example #29551

Merged
merged 1 commit into from
Jun 16, 2021
Merged

docs: fix setWindowOpenHandler invocation in window.open example #29551

merged 1 commit into from
Jun 16, 2021

Conversation

kdau
Copy link
Contributor

@kdau kdau commented Jun 5, 2021

Description of Change

The "Native Window example" in docs/api/window-open.md calls webContents.setWindowOpenHandler incorrectly. This PR fixes the call, in line with previous fixes to other calls in this document.

Checklist

Release Notes

Notes: Fixed invocation of webContents.setWindowOpenHandler in window.open example.

@welcome
Copy link

welcome bot commented Jun 5, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 5, 2021
@kdau kdau changed the title fix setWindowOpenHandler call syntax docs: fix setWindowOpenHandler invocation in window.open example Jun 5, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 12, 2021
@zcbenz zcbenz merged commit 226f2a9 into electron:main Jun 16, 2021
@welcome
Copy link

welcome bot commented Jun 16, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jun 16, 2021

Release Notes Persisted

Fixed invocation of webContents.setWindowOpenHandler in window.open example.

@trop
Copy link
Contributor

trop bot commented Jun 16, 2021

I have automatically backported this PR to "12-x-y", please check out #29725

@trop
Copy link
Contributor

trop bot commented Jun 16, 2021

I have automatically backported this PR to "13-x-y", please check out #29726

@trop
Copy link
Contributor

trop bot commented Jun 16, 2021

I have automatically backported this PR to "14-x-y", please check out #29727

@trop trop bot removed the in-flight/12-x-y label Jun 16, 2021
@kdau kdau deleted the patch-1 branch June 17, 2021 05:59
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants