fix: select element not working on Windows #29742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Jun 16, 2021
MarshallOfSound
approved these changes
Jun 17, 2021
@codebytere I didn't comment on #29665, but this reproduces on Ubuntu as well. Does the fix account for that? |
|
@Prinzhorn it does! The issue was that the function should be called only on macOS (or Android, but that's not relevant to Electron) and this makes that the case again. |
|
@codebytere thanks! You might want to update the release notes to reflect that. |
|
Release Notes Persisted
|
|
I have automatically backported this PR to "14-x-y", please check out #29771 |
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #29665.
Refs #28938 - previously the call to
blink::WebView::SetUseExternalPopupMenuwas guarded byUSE_EXTERNAL_POPUP_MENU- the refactor removed this for the moved call to the selfsame function but that flag is only defined on macOS and Android. This caused the element dropdown to stop working on Windows. We don't have access toUSE_EXTERNAL_POPUP_MENUwithin Blink so just fix this by moving inside a macOS-only guard.Checklist
npm testpassesRelease Notes
Notes: Fixed the
<select>element dropdown not appearing on Windows or Linux.