Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Docs and TS typings for setPermissionRequestHandler are out of date #30000

Open
3 tasks done
jmrossy opened this issue Jul 3, 2021 · 9 comments
Open
3 tasks done
Labels
13-x-y bug 🪲 documentation 📓 platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@jmrossy
Copy link

jmrossy commented Jul 3, 2021

Preflight Checklist

Electron Version

13.1.1

What operating system are you using?

macOS

Operating System Version

Not relevant

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

Correct typings and complete docs for the setPermissionRequestHandler API and the permissions it handles.

Actual Behavior

The list of permissions for in the API's documentation don't include all the possible permission types.

Likewise, the Typescript typings for the API are missing some.

The full list of permission types seems to be here:

case content::PermissionType::ACCESSIBILITY_EVENTS:

Testcase Gist URL

No response

Additional Information

No response

@jmrossy
Copy link
Author

jmrossy commented Jul 3, 2021

Oh, I guess this happens to be item number 30000! Congrats to all the Electron maintainers for hitting this milestone and thanks for all the great work you do! 🙏

@VerteDinde VerteDinde added 13-x-y documentation 📓 platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature labels Jul 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 5, 2022
@jmrossy
Copy link
Author

jmrossy commented Oct 6, 2022

Bump, the documentation is not yet updated.

@github-actions github-actions bot removed the stale label Oct 7, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Jan 10, 2023
@jmrossy
Copy link
Author

jmrossy commented Jan 10, 2023

Bump, the documentation is still not yet updated.

@github-actions github-actions bot removed the stale label Jan 11, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Apr 12, 2023
@jmrossy
Copy link
Author

jmrossy commented Apr 12, 2023

bump

@github-actions github-actions bot removed the stale label Apr 13, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Jul 12, 2023
@jmrossy
Copy link
Author

jmrossy commented Jul 12, 2023

bump

@github-actions github-actions bot removed the stale label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13-x-y bug 🪲 documentation 📓 platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
None yet
Development

No branches or pull requests

2 participants