-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Docs and TS typings for setPermissionRequestHandler are out of date #30000
Comments
Oh, I guess this happens to be item number 30000! Congrats to all the Electron maintainers for hitting this milestone and thanks for all the great work you do! 🙏 |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
Bump, the documentation is not yet updated. |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
Bump, the documentation is still not yet updated. |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
bump |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
bump |
Preflight Checklist
Electron Version
13.1.1
What operating system are you using?
macOS
Operating System Version
Not relevant
What arch are you using?
x64
Last Known Working Electron version
No response
Expected Behavior
Correct typings and complete docs for the
setPermissionRequestHandler
API and the permissions it handles.Actual Behavior
The list of permissions for in the API's documentation don't include all the possible permission types.
Likewise, the Typescript typings for the API are missing some.
The full list of permission types seems to be here:
electron/shell/common/gin_converters/content_converter.cc
Line 142 in 44491b0
Testcase Gist URL
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: