[Bug]: "View" linux notification action is not localized

[scottnonnenberg-signal]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Electron Version

13.1.6

What operating system are you using?

Ubuntu

Operating System Version

Ubuntu 20.04.2 LTS

What arch are you using?

x64

Last Known Working Electron version

none

Expected Behavior

On German OS, the action that comes along with a notification is translated.

Actual Behavior

On German OS, the action that comes along with a notification is the english string "View."

Testcase Gist URL

No response

Additional Information

Thanks to the great investigative work of @Sgn-32, a Signal Desktop user, here... signalapp/Signal-Desktop#5402

...we've established that Electron is using an un-localized "View" string when creating linux notifications with an action:

electron/shell/browser/notifications/linux/libnotify_notification.cc

Lines 94 to 100 in 461db8f

	// NB: On Unity and on any other DE using Notify-OSD, adding a notification
	// action will cause the notification to display as a modal dialog box.
	if (NotifierSupportsActions()) {
	libnotify_loader_.notify_notification_add_action(
	notification_, "default", "View", OnNotificationViewThunk, this,
	nullptr);
	}

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[scottnonnenberg-signal]

The hardcoded "View" is still there:

electron/shell/browser/notifications/linux/libnotify_notification.cc

Lines 93 to 99 in f916ce2

	// NB: On Unity and on any other DE using Notify-OSD, adding a notification
	// action will cause the notification to display as a modal dialog box.
	if (NotifierSupportsActions()) {
	libnotify_loader_.notify_notification_add_action(
	notification_, "default", "View", OnNotificationViewThunk, this,
	nullptr);
	}

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[scottnonnenberg-signal]

Even in the 23.x.y branch the hardcoded "View" is still there:

https://github.com/electron/electron/blob/23-x-y/shell/browser/notifications/linux/libnotify_notification.cc#L93-L99

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[scottnonnenberg-signal]

Even in the 25-x-y branch, the hardcoded "View" string is there:

electron/shell/browser/notifications/linux/libnotify_notification.cc

Lines 95 to 99 in 95b727c

	if (NotifierSupportsActions()) {
	libnotify_loader_.notify_notification_add_action(
	notification_, "default", "View", OnNotificationViewThunk, this,
	nullptr);
	}

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[scottnonnenberg-signal]

The hardcode string is still there in the 26-x-y branch:

electron/shell/browser/notifications/linux/libnotify_notification.cc

Lines 95 to 99 in 5ab5427

	if (NotifierSupportsActions()) {
	libnotify_loader_.notify_notification_add_action(
	notification_, "default", "View", OnNotificationViewThunk, this,
	nullptr);
	}

[electron-issue-triage]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[Sgn-32]

The hardcode string is still there in the 27-x-y branch:

electron/shell/browser/notifications/linux/libnotify_notification.cc

Lines 98 to 101 in 5d6023a

	if (NotifierSupportsActions()) {
	libnotify_loader_.notify_notification_add_action(
	notification_, "default", "View", OnNotificationView, this, nullptr);
	}

[electron-issue-triage]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[Sgn-32]

The hardcode string is still there in the 28-x-y branch:

electron/shell/browser/notifications/linux/libnotify_notification.cc

Lines 98 to 101 in 80b220d

	if (NotifierSupportsActions()) {
	libnotify_loader_.notify_notification_add_action(
	notification_, "default", "View", OnNotificationView, this, nullptr);
	}

[electron-issue-triage]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[Sgn-32]

electron/shell/browser/notifications/linux/libnotify_notification.cc

Lines 96 to 101 in 75dae2e

	// NB: On Unity and on any other DE using Notify-OSD, adding a notification
	// action will cause the notification to display as a modal dialog box.
	if (NotifierSupportsActions()) {
	libnotify_loader_.notify_notification_add_action(
	notification_, "default", "View", OnNotificationView, this, nullptr);
	}