[Bug]: Crash in AppendExtraCommandLineSwitches when clicking a link on Linux

[indutny-signal]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Electron Version

17-x-y

What operating system are you using?

Ubuntu

Operating System Version

Ubuntu 20.04

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

No crashes

Actual Behavior

Our users report that their app crashed when they clicked on a link in the BrowserWindow. Here are the crash reporter dumps: https://gist.github.com/indutny-signal/b42dd2e19b959a85aa1e545cc140df6e

Testcase Gist URL

No response

Additional Information

Unfortunately, we do not have a repro for this and it seems to happen very rarely.

[codebytere]

@indutny-signal I believe it's CHECKing here:

electron/shell/browser/electron_browser_client.cc

Lines 549 to 551 in ebfcf89

	if (!base::PathService::Get(content::CHILD_PROCESS_EXE, &child_path)) {
	CHECK(false) << "Unable to get child process binary name.";
	}

We might want to consider a softer way to handle that 🤔

cc @nornagon who added this in #27804 - maybe we should LOG(ERROR) instead of CHECKing?

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[github-actions]

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.