Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gather crash data for unexpected helper path #27804

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

nornagon
Copy link
Member

Description of Change

Adds some crash keys for path data when the child process exe path is found to
be different from the parent's path on win/linux.

We're seeing this CHECK fire in production, and this will hopefully help us
narrow down the cause!

Checklist

  • PR description included and stakeholders cc'd

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 18, 2021
@nornagon nornagon added semver/patch backwards-compatible bug fixes target/12-x-y labels Feb 19, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 19, 2021
@nornagon nornagon merged commit 1e4f67c into master Feb 19, 2021
@release-clerk
Copy link

release-clerk bot commented Feb 19, 2021

No Release Notes

@nornagon nornagon deleted the path-crash-telemetry branch February 19, 2021 23:08
@trop
Copy link
Contributor

trop bot commented Feb 19, 2021

I have automatically backported this PR to "12-x-y", please check out #27828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants