Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Re add Linux 32bit #34783

Closed
3 tasks done
coreybruce opened this issue Jun 29, 2022 · 8 comments · Fixed by #34787
Closed
3 tasks done

[Feature Request]: Re add Linux 32bit #34783

coreybruce opened this issue Jun 29, 2022 · 8 comments · Fixed by #34787
Labels
enhancement ✨

Comments

@coreybruce
Copy link

coreybruce commented Jun 29, 2022 •
edited
Loading

Preflight Checklist

Problem Description

Linux 32bit binaries are missing as Linux 32bit distros like Arch32, Gentoo, Void, Debian etc still all support Linux 32bit

Proposed Solution

Re add Linux 32bit binaries

Alternatives Considered

N/A

Additional Information

No response
@RaisinTen
Copy link
Contributor

IA32 Linux support was dropped in 389ef07 in #33731 but the PR doesn't document the reason in docs/breaking-changes.md. Was that intentional @codebytere?

@codebytere
Copy link
Member

codebytere commented Jun 29, 2022 •
edited
Loading

No - it was the result of an upstream change in Chromium that forced our hand. We can probably add it to breaking changes - typically what ends up there is planned changes which is why this was missed.

@RaisinTen
Copy link
Contributor

result of an upstream change in Chromium that forced our hand

Curious if you have a link to the upstream change. Did it get fixed later on in Chromium or is it not possible (and will never be?) to build chromium for 32-bit Linux anymore?

@codebytere
Copy link
Member

codebytere commented Jun 29, 2022 •
edited
Loading

It was removed in Chromium permanently - i can try to find the CL. https://bugs.chromium.org/p/chromium/issues/detail?id=1194538 discusses it though!

RaisinTen added a commit to RaisinTen/electron that referenced this issue Jun 29, 2022
@RaisinTen
docs: document the removal of IA32 Linux support
c76c7ed 
Chromium had dropped support for IA32 Linux, so the Chromium
102.0.4999.0 upgrade PR,
electron#33731, had introduced the commit,
electron@389ef07,
to drop support for IA32 Linux but the change landed without an addition
to the documentation for the breaking changes, so this PR adds that.

Closes: electron#34783
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen RaisinTen mentioned this issue Jun 29, 2022
Merged
3 tasks
@RaisinTen
Copy link
Contributor

We can probably add it to breaking changes

I guess that's the only thing we can do at this point, sent #34787 to do that.

i can try to find the CL.

Cool, we can add that info to the docs / the PR description if you think that's relevant.

@coreybruce
Copy link
Author

coreybruce commented Jun 29, 2022 •
edited
Loading

Is there a chance this could get fixed and re-added?

You can also use this argument to make electron 18.x.x work on 32bit Linux

--disable-seccomp-filter-sandbox

@codebytere
Copy link
Member

codebytere commented Jun 29, 2022 •
edited
Loading

@coreybruce sadly no - given it's not supported by Chromium it's likely to face constant breakage and we're not prepared to take on sole maintenance burden for keeping it alive. We have similar policies across OSes - for ex. we drop macOS versions and Windows versions when upstream does as well.

@codebytere codebytere closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2022
@coreybruce
Copy link
Author

Ahh that's a real shame, I wouldn't even care if Electron for 32bit was behind for stability

RaisinTen added a commit to RaisinTen/electron that referenced this issue Jun 29, 2022
@RaisinTen
docs: document the removal of IA32 Linux support
a076b92 
Chromium had dropped support for IA32 Linux, so the Chromium
102.0.4999.0 upgrade PR,
electron#33731, had introduced the commit,
electron@389ef07,
to drop support for IA32 Linux but the change landed without an addition
to the documentation for the breaking changes, so this PR adds that.

Closes: electron#34783
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1194538
Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen added a commit to RaisinTen/electron that referenced this issue Jun 29, 2022
@RaisinTen
docs: document the removal of IA32 Linux support
c23100f 
Chromium had dropped support for IA32 Linux, so the Chromium
102.0.4999.0 upgrade PR,
electron#33731, had introduced the commit,
electron@389ef07,
to drop support for IA32 Linux but the change landed without an addition
to the documentation for the breaking changes, so this PR adds that.

Closes: electron#34783
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1194538
Signed-off-by: Darshan Sen <raisinten@gmail.com>
VerteDinde added a commit that referenced this issue Jun 30, 2022
@RaisinTen @nornagon @VerteDinde
docs: document the removal of IA32 Linux support (#34787)
c885f90 
* docs: document the removal of IA32 Linux support

Chromium had dropped support for IA32 Linux, so the Chromium
102.0.4999.0 upgrade PR,
#33731, had introduced the commit,
389ef07,
to drop support for IA32 Linux but the change landed without an addition
to the documentation for the breaking changes, so this PR adds that.

Closes: #34783
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1194538
Signed-off-by: Darshan Sen <raisinten@gmail.com>

* Update docs/breaking-changes.md

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
trop bot pushed a commit that referenced this issue Jun 30, 2022
@RaisinTen @electron-bot
docs: document the removal of IA32 Linux support
7f3a102 
Chromium had dropped support for IA32 Linux, so the Chromium
102.0.4999.0 upgrade PR,
#33731, had introduced the commit,
389ef07,
to drop support for IA32 Linux but the change landed without an addition
to the documentation for the breaking changes, so this PR adds that.

Closes: #34783
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1194538
Signed-off-by: Darshan Sen <raisinten@gmail.com>
trop bot pushed a commit that referenced this issue Jun 30, 2022
@RaisinTen @electron-bot
docs: document the removal of IA32 Linux support
3a5d50d 
Chromium had dropped support for IA32 Linux, so the Chromium
102.0.4999.0 upgrade PR,
#33731, had introduced the commit,
389ef07,
to drop support for IA32 Linux but the change landed without an addition
to the documentation for the breaking changes, so this PR adds that.

Closes: #34783
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1194538
Signed-off-by: Darshan Sen <raisinten@gmail.com>
VerteDinde added a commit that referenced this issue Jun 30, 2022
@trop @RaisinTen
@nornagon @VerteDinde
docs: document the removal of IA32 Linux support (#34806)
9d7b59e 
* docs: document the removal of IA32 Linux support

Chromium had dropped support for IA32 Linux, so the Chromium
102.0.4999.0 upgrade PR,
#33731, had introduced the commit,
389ef07,
to drop support for IA32 Linux but the change landed without an addition
to the documentation for the breaking changes, so this PR adds that.

Closes: #34783
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1194538
Signed-off-by: Darshan Sen <raisinten@gmail.com>

* Update docs/breaking-changes.md

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>

Co-authored-by: Darshan Sen <raisinten@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
VerteDinde added a commit that referenced this issue Jul 1, 2022
@trop @RaisinTen
@nornagon @VerteDinde
docs: document the removal of IA32 Linux support (#34805)
af4f598 
* docs: document the removal of IA32 Linux support

Chromium had dropped support for IA32 Linux, so the Chromium
102.0.4999.0 upgrade PR,
#33731, had introduced the commit,
389ef07,
to drop support for IA32 Linux but the change landed without an addition
to the documentation for the breaking changes, so this PR adds that.

Closes: #34783
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1194538
Signed-off-by: Darshan Sen <raisinten@gmail.com>

* Update docs/breaking-changes.md

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>

Co-authored-by: Darshan Sen <raisinten@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
schetle pushed a commit to schetle/electron that referenced this issue Nov 3, 2022
@RaisinTen @nornagon
@VerteDinde @schetle
docs: document the removal of IA32 Linux support (electron#34787)
43f4088 
* docs: document the removal of IA32 Linux support

Chromium had dropped support for IA32 Linux, so the Chromium
102.0.4999.0 upgrade PR,
electron#33731, had introduced the commit,
electron@389ef07,
to drop support for IA32 Linux but the change landed without an addition
to the documentation for the breaking changes, so this PR adds that.

Closes: electron#34783
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1194538
Signed-off-by: Darshan Sen <raisinten@gmail.com>

* Update docs/breaking-changes.md

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
khalwa pushed a commit to solarwindscloud/electron that referenced this issue Feb 22, 2023
@RaisinTen @nornagon
@VerteDinde @khalwa
docs: document the removal of IA32 Linux support (electron#34787)
2112aa6 
* docs: document the removal of IA32 Linux support

Chromium had dropped support for IA32 Linux, so the Chromium
102.0.4999.0 upgrade PR,
electron#33731, had introduced the commit,
electron@389ef07,
to drop support for IA32 Linux but the change landed without an addition
to the documentation for the breaking changes, so this PR adds that.

Closes: electron#34783
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1194538
Signed-off-by: Darshan Sen <raisinten@gmail.com>

* Update docs/breaking-changes.md

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: document the removal of IA32 Linux support RaisinTen/electron
3 participants
@codebytere @coreybruce @RaisinTen