Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: wayland window decorations mangled and not clickable #34820

Closed
3 tasks done
csett86 opened this issue Jul 4, 2022 · 4 comments · Fixed by #34955
Closed
3 tasks done

[Bug]: wayland window decorations mangled and not clickable #34820

csett86 opened this issue Jul 4, 2022 · 4 comments · Fixed by #34955
Labels
19-x-y 20-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/linux wayland

Comments

@csett86
Copy link

csett86 commented Jul 4, 2022

Preflight Checklist

Electron Version

19.0.7

What operating system are you using?

Ubuntu

Operating System Version

22.04

What arch are you using?

x64

Last Known Working Electron version

19.0.0-alpha.3

Expected Behavior

Running under wayland natively (--ozone-platform=wayland) and enabling window decorations (app.commandLine.appendSwitch('enable-features', 'WaylandWindowDecorations'); in main.js) should show a title bar which is clickable.

Below is from 19.0.0-alpha.3 where it still worked:

grafik

Actual Behavior

Running under wayland natively (--ozone-platform=wayland) and enabling window decorations (app.commandLine.appendSwitch('enable-features', 'WaylandWindowDecorations'); in main.js) shows mangled transparent border on the left side instead of a title bar and is not clickable:

On electron 19 is broke during the alpha and beta cycle:

Below is from 19.0.0-alpha.4 where it first broke, here the buttons are still clickable:

grafik

Starting with 19.0.0-beta.4 the buttons are also no longer clickable:

grafik

With 19.0.0 up and until 19.0.7 the same, broken titlebar and not clickable:

grafik

On electron 18-x-y it also broke between 18.2.0 and 18.2.1, but only the buttons cannot be clicked any longer:

18.2.0 still everything ok, titlebar there and clickable:

grafik

18.2.1: Titlebar still there, but no longer clickable:

grafik

Up and including 18.3.5 the titlebar stays there, but not clickable:

grafik

Testcase Gist URL

https://gist.github.com/csett86/5d45c47cb1d5331b9ede0788ff5ae284

Additional Information

To reproduce with the gist, you need to add --ozone-platform=wayland to the user-provided flags, as I could find a way to add this to the fiddle (the WaylandWindowDecorations are part of the fiddle):

grafik

@csett86
Copy link
Author

csett86 commented Jul 4, 2022

I also already tried myself if I could spot an obvious commit that broke it on either 18 or 19 between the mentioned releases, but so far had no luck there.

@csett86
Copy link
Author

csett86 commented Jul 4, 2022

FYI @refi64

@refi64
Copy link
Contributor

refi64 commented Jul 6, 2022

I'll make sure to look into this soon-ish, but it might take a hot minute.

@GrantMoyer
Copy link

GrantMoyer commented Jul 14, 2022

I ran a git bisect. The mangled decorations were introduced by 7c0ed9e … somehow. I double checked too; no mangled decorations in the parent commit, mangled in 7c0ed9e.

I did not test for when clickability broke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
19-x-y 20-x-y bug 🪲 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/linux wayland
Projects
No open projects
Status: Does Not Block Stable
Development

Successfully merging a pull request may close this issue.

5 participants