Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wrong TypeScript type of ses.getStoragePath #35255

Closed
3 tasks done
datenreisender opened this issue Aug 8, 2022 · 0 comments · Fixed by #35288
Closed
3 tasks done

[Bug]: Wrong TypeScript type of ses.getStoragePath #35255

datenreisender opened this issue Aug 8, 2022 · 0 comments · Fixed by #35288
Labels
20-x-y bug 🪲 component/typescript status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@datenreisender
Copy link

Preflight Checklist

Electron Version

20.0.1

What operating system are you using?

macOS

Operating System Version

macOS Monterey 12.5

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

The return type of ses.getStoragePath() should be string | null. This is returned when actually calling the function and is also described in https://github.com/electron/electron/blob/91f9436ad8e6028bf2909008e5814867289b9310/docs/api/session.md#sesgetstoragepath.

Actual Behavior

The generated TypeScript type definition says ses.getStoragePath() returns void, as can also be seen in https://unpkg.com/browse/electron@20.0.1/electron.d.ts#L7763.

Testcase Gist URL

No response

Additional Information

No response

@clavin clavin added component/typescript status/confirmed A maintainer reproduced the bug or agreed with the feature 20-x-y labels Aug 8, 2022
trop bot pushed a commit that referenced this issue Aug 10, 2022
trop bot pushed a commit that referenced this issue Aug 10, 2022
trop bot pushed a commit that referenced this issue Aug 10, 2022
Dragon-S pushed a commit to Dragon-S/electron that referenced this issue Aug 11, 2022
Fixes electron#35255

Co-authored-by: Samuel Attard <sam@electronjs.org>
mlaurencin pushed a commit that referenced this issue Aug 31, 2022
Fixes #35255

Co-authored-by: Samuel Attard <sam@electronjs.org>
rzhao271 pushed a commit to rzhao271/electron that referenced this issue Oct 10, 2022
Fixes electron#35255

Co-authored-by: Samuel Attard <sam@electronjs.org>
schetle pushed a commit to schetle/electron that referenced this issue Nov 3, 2022
khalwa pushed a commit to solarwindscloud/electron that referenced this issue Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-x-y bug 🪲 component/typescript status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants