Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: don't expose deprecate as an internal module #35311

Merged
merged 1 commit into from Aug 15, 2022
Merged

refactor: don't expose deprecate as an internal module #35311

merged 1 commit into from Aug 15, 2022

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Aug 11, 2022 •
edited

Description of Change

This was the last private module to be removed after #19139, #15920 and #14389

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added

Release Notes

Notes: none

@miniak miniak added the wip ⚒ label Aug 11, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 11, 2022
@miniak miniak marked this pull request as ready for review August 11, 2022 21:29
@miniak miniak removed the wip ⚒ label Aug 11, 2022
@miniak miniak force-pushed the miniak/deprecate-module branch 4 times, most recently from 1152139 to 9954b7c Compare August 11, 2022 21:45
@miniak miniak added semver/patch backwards-compatible bug fixes no-backport labels Aug 11, 2022
@miniak miniak self-assigned this Aug 11, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 12, 2022
@zcbenz zcbenz merged commit 8424779 into main Aug 15, 2022
@zcbenz zcbenz deleted the miniak/deprecate-module branch August 15, 2022 08:09
@release-clerk
Copy link

release-clerk bot commented Aug 15, 2022

No Release Notes

@commit-lint commit-lint bot mentioned this pull request Oct 27, 2022
Open
schetle pushed a commit to schetle/electron that referenced this pull request Nov 3, 2022
@miniak @schetle
refactor: don't expose deprecate as an internal module (electron#35311)
ef9552b
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@miniak @khalwa
refactor: don't expose deprecate as an internal module (electron#35311)
db7fadb
@miniak miniak mentioned this pull request Oct 6, 2023
Merged
3 tasks
miniak added a commit that referenced this pull request Oct 6, 2023
@miniak
Revert "refactor: don't expose deprecate as an internal module (#35311)"
872bb65 
This reverts commit 8424779.
@miniak miniak mentioned this pull request Oct 6, 2023
Merged
miniak added a commit that referenced this pull request Oct 6, 2023
@miniak
Revert "refactor: don't expose deprecate as an internal module (#35311)"
8d36be2 
This reverts commit 8424779.
miniak added a commit that referenced this pull request Oct 6, 2023
@miniak
Revert "refactor: don't expose deprecate as an internal module (#35311)"
120be48 
This reverts commit 8424779.
miniak added a commit that referenced this pull request Oct 6, 2023
@miniak
Revert "refactor: don't expose deprecate as an internal module (#35311)"
eaf4ea0 
This reverts commit 8424779.
miniak added a commit that referenced this pull request Oct 6, 2023
@miniak
Revert "refactor: don't expose deprecate as an internal module (#35311)"
1070697 
This reverts commit 8424779.
miniak added a commit that referenced this pull request Oct 7, 2023
@miniak
Revert "refactor: don't expose deprecate as an internal module (#35311)"
093212a 
This reverts commit 8424779.
zcbenz pushed a commit that referenced this pull request Oct 8, 2023
@miniak
chore: restore deprecate as an internal module (#40124)
737e3de 
* Revert "refactor: don't expose deprecate as an internal module (#35311)"

This reverts commit 8424779.

* check crashed event warnings
@miniak miniak mentioned this pull request Oct 9, 2023
Merged
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
chore: restore deprecate as an internal module (electron#40124)
e9495a5 
* Revert "refactor: don't expose deprecate as an internal module (electron#35311)"

This reverts commit 8424779.

* check crashed event warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees

@miniak miniak

Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @zcbenz @deepak1556