Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert deprecate as an internal module #40146

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 9, 2023

Re-land #35311 (reverting #40124) and use expectDeprecationMessages from #39405

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 9, 2023
@miniak miniak self-assigned this Oct 9, 2023
@miniak miniak added semver/patch backwards-compatible bug fixes no-backport labels Oct 9, 2023
@miniak miniak requested a review from codebytere October 9, 2023 13:27
@miniak miniak changed the title chore: don't expose deprecate as an internal module chore: revert restore deprecate as an internal module Oct 9, 2023
@miniak miniak changed the title chore: revert restore deprecate as an internal module chore: revert deprecate as an internal module Oct 9, 2023
@miniak miniak added target/27-x-y PR should also be added to the "27-x-y" branch. no-backport and removed no-backport target/27-x-y PR should also be added to the "27-x-y" branch. labels Oct 10, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 10, 2023
@miniak
Copy link
Contributor Author

miniak commented Oct 10, 2023

@codebytere can you merge please?

@jkleinsc jkleinsc merged commit 2c88626 into main Oct 10, 2023
24 checks passed
@jkleinsc jkleinsc deleted the miniak/remove-deprecate-module branch October 10, 2023 15:50
@release-clerk
Copy link

release-clerk bot commented Oct 10, 2023

No Release Notes

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
Revert "chore: restore deprecate as an internal module (electron#40124)"

This reverts commit 737e3de.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants