Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use AppVeyor workflows #35377

Merged
merged 2 commits into from Aug 19, 2022
Merged

ci: use AppVeyor workflows #35377

merged 2 commits into from Aug 19, 2022

Conversation

jkleinsc
Copy link
Contributor

Description of Change

This PR splits up our Windows CI into two jobs: build and test. This means that we can re-run just the tests if needed which is much quicker than re-running the whole build and test.

Checklist

Release Notes

Notes: none

@jkleinsc jkleinsc added target/19-x-y target/21-x-y PR should also be added to the "21-x-y" branch. labels Aug 18, 2022
@jkleinsc jkleinsc merged commit 9b787d3 into main Aug 19, 2022
@jkleinsc jkleinsc deleted the appveyor-use-workflows branch August 19, 2022 17:10
@release-clerk
Copy link

release-clerk bot commented Aug 19, 2022

No Release Notes

@trop
Copy link
Contributor

trop bot commented Aug 19, 2022

I was unable to backport this PR to "19-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 19, 2022

I was unable to backport this PR to "20-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 19, 2022

I was unable to backport this PR to "21-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/20-x-y needs-manual-bp/21-x-y and removed target/21-x-y PR should also be added to the "21-x-y" branch. labels Aug 19, 2022
VerteDinde pushed a commit that referenced this pull request Oct 13, 2022
* ci: use AppVeyor workflows

* fixup for skipping test on pr jobs
@trop
Copy link
Contributor

trop bot commented Oct 13, 2022

@VerteDinde has manually backported this PR to "21-x-y", please check out #36028

VerteDinde pushed a commit that referenced this pull request Oct 13, 2022
* ci: use AppVeyor workflows

* fixup for skipping test on pr jobs
VerteDinde pushed a commit that referenced this pull request Oct 13, 2022
* ci: use AppVeyor workflows

* fixup for skipping test on pr jobs
@trop trop bot removed the in-flight/21-x-y label Oct 16, 2022
@trop trop bot added the merged/21-x-y PR was merged to the "21-x-y" branch. label Oct 16, 2022
MarshallOfSound pushed a commit that referenced this pull request Oct 16, 2022
* ci: use AppVeyor workflows (#35377)

* ci: use AppVeyor workflows

* fixup for skipping test on pr jobs

* ci: clean up appveyor.yml to match main

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
VerteDinde pushed a commit that referenced this pull request Nov 16, 2022
* ci: use AppVeyor workflows

* fixup for skipping test on pr jobs
@trop
Copy link
Contributor

trop bot commented Nov 16, 2022

@VerteDinde has manually backported this PR to "20-x-y", please check out #36377

jkleinsc added a commit that referenced this pull request Nov 17, 2022
* ci: use AppVeyor workflows (#35377)

* ci: use AppVeyor workflows

* fixup for skipping test on pr jobs

* chore: remove builtins-pgo (does not exist in 20)

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
* ci: use AppVeyor workflows

* fixup for skipping test on pr jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/21-x-y PR was merged to the "21-x-y" branch. semver/none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants