Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: make sure artifacts are saved for fork PRs #35593

Merged
merged 1 commit into from
Sep 7, 2022
Merged

ci: make sure artifacts are saved for fork PRs #35593

merged 1 commit into from
Sep 7, 2022

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Sep 7, 2022 •
edited

Description of Change

  • ci: use AppVeyor workflows #35377 inadvertently broke fork PR CI testing on Windows because it no longer was saving artifacts for fork PRs. This PR fixes the saving of artifacts so that fork PRs can properly run tests.

Checklist

Release Notes

Notes: none

@codebytere codebytere added the fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases label Sep 7, 2022
@jkleinsc
Copy link
Contributor Author

jkleinsc commented Sep 7, 2022

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit ebd1c83 into main Sep 7, 2022
@jkleinsc jkleinsc deleted the fixup-forkprs-appveyor branch September 7, 2022 17:25
@release-clerk
Copy link

release-clerk bot commented Sep 7, 2022

No Release Notes

@itsananderson itsananderson mentioned this pull request Sep 7, 2022
Merged
5 tasks
@matthewloft matthewloft mentioned this pull request Sep 8, 2022
Closed
3 tasks
@commit-lint commit-lint bot mentioned this pull request Dec 8, 2022
Open
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@jkleinsc @khalwa
ci: make sure artifacts are saved for fork PRs (electron#35593)
77119ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases no-backport semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @codebytere