Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: File extension appended multiple times to file name when saving #35594

Closed
3 tasks done
trippier1 opened this issue Sep 7, 2022 · 0 comments · Fixed by #35618
Closed
3 tasks done

[Bug]: File extension appended multiple times to file name when saving #35594

trippier1 opened this issue Sep 7, 2022 · 0 comments · Fixed by #35618
Labels
18-x-y 19-x-y 20-x-y bug 🪲 platform/windows status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@trippier1
Copy link

trippier1 commented Sep 7, 2022 •
edited

Preflight Checklist

Electron Version

20.1.1

All latest 18.x.y, 19.x.y and 20.x.y versions are affected.

What operating system are you using?

Windows

Operating System Version

Windows 10 Version 20H2

What arch are you using?

x64

Last Known Working Electron version

19.0.7

Expected Behavior

When saving/downloading a file, file name should be saved with the given file extension.

Actual Behavior

File extension is appended three times to file name with double dots, like:
<file_name>.<file_extension>..<file_extension>..<file_extension>
Issue happens for file extensions which are not in registry.
For file types which are in registry, file name is fine.

Testcase Gist URL

https://gist.github.com/dfa6a6e75b43e475f285df9e0f743650

Additional Information

Most likely related to the change #34723
@mlaurencin mlaurencin added 18-x-y 19-x-y 20-x-y platform/windows status/confirmed A maintainer reproduced the bug or agreed with the feature labels Sep 7, 2022
@mlaurencin mlaurencin mentioned this issue Sep 8, 2022
Merged
3 tasks
GarboMuffin added a commit to TurboWarp/packager that referenced this issue Nov 13, 2022
@GarboMuffin
Update electron-win assets to 21.2.3
a8194e6 
Part of TurboWarp/extensions#28
Electron 21.2.0 fixes electron/electron#35594
Seems that updating the other platforms is not necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
18-x-y 19-x-y 20-x-y bug 🪲 platform/windows status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
No open projects
21-x-y
Status: Fixed For Next Release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove extra dot in extension electron/electron
2 participants
@mlaurencin @trippier1