fix: restoring X11 window should not remove previous maximize state #37358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
5 tasks
trop
bot
added
24-x-y
backport
codebytere
approved these changes
Feb 21, 2023
codebytere
deleted the
trop/24-x-y-bp-fix-restoring-x11-window-should-not-remove-previous-maximize-state-1676969365530
branch
|
Release Notes Persisted
|
vikunja-bot
pushed a commit
to go-vikunja/desktop
that referenced
this pull request
Feb 23, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [electron](https://github.com/electron/electron) | devDependencies | patch | [`23.1.0` -> `23.1.1`](https://renovatebot.com/diffs/npm/electron/23.1.0/23.1.1) | --- ### Release Notes <details> <summary>electron/electron</summary> ### [`v23.1.1`](https://github.com/electron/electron/releases/tag/v23.1.1) [Compare Source](electron/electron@v23.1.0...v23.1.1) ### Release Notes for v23.1.1 #### Fixes - Corrects an issue with HTML fullscreen when `BrowserWindow` fullscreening is disabled. [#​37367](electron/electron#37367) <span style="font-size:small;">(Also in [24](https://github.com/electron/electron/pull/37368))</span> - Fixed potential private API usage for MAS builds on macOS. [#​37363](electron/electron#37363) <span style="font-size:small;">(Also in [24](https://github.com/electron/electron/pull/37364))</span> - Fixed window could not go back to maximized state when restored on Linux. [#​37359](electron/electron#37359) <span style="font-size:small;">(Also in [24](https://github.com/electron/electron/pull/37358))</span> #### Other Changes - Security: backported fix for chromium:1408392. [#​37297](electron/electron#37297) - Updated Chromium to 110.0.5481.104. [#​37333](electron/electron#37333) #### Documentation - Documentation changes: [#​37290](electron/electron#37290) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDAuMiIsInVwZGF0ZWRJblZlciI6IjMyLjI0MC4yIn0=--> Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/139 Co-authored-by: renovate <renovatebot@kolaente.de> Co-committed-by: renovate <renovatebot@kolaente.de>
55 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #37346
See that PR for details.
Notes: Fix window could not go back to maximized state when restored on Linux.