Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restoring X11 window should not remove previous maximize state #37346

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: restoring X11 window should not remove previous maximize state #37346

merged 1 commit into from
Feb 21, 2023

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Feb 20, 2023

Description of Change

Backport the fix in https://chromium-review.googlesource.com/c/chromium/src/+/4252946, and close #30575.

Checklist

Release Notes

Notes: Fix window could not go back to maximized state when restored on Linux.

@zcbenz zcbenz requested a review from a team as a code owner February 20, 2023 05:28
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 20, 2023
@zcbenz zcbenz added semver/patch backwards-compatible bug fixes target/22-x-y PR should also be added to the "22-x-y" branch. target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. labels Feb 20, 2023
Dizopizo
Dizopizo reviewed Feb 20, 2023
View reviewed changes
Copy link

@Dizopizo Dizopizo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 21, 2023
@codebytere codebytere merged commit a92fd2a into main Feb 21, 2023
@codebytere codebytere deleted the fix-x11-restore-window branch February 21, 2023 08:49
@release-clerk
Copy link

release-clerk bot commented Feb 21, 2023

Release Notes Persisted

Fix window could not go back to maximized state when restored on Linux.

This was referenced Feb 21, 2023
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Feb 21, 2023

I have automatically backported this PR to "24-x-y", please check out #37358

@trop trop bot added in-flight/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Feb 21, 2023
@trop
Copy link
Contributor

trop bot commented Feb 21, 2023

I have automatically backported this PR to "23-x-y", please check out #37359

@trop
Copy link
Contributor

trop bot commented Feb 21, 2023

I have automatically backported this PR to "22-x-y", please check out #37360

@trop trop bot added in-flight/23-x-y merged/24-x-y PR was merged to the "24-x-y" branch merged/23-x-y PR was merged to the "23-x-y" branch. and removed target/23-x-y PR should also be added to the "23-x-y" branch. target/22-x-y PR should also be added to the "22-x-y" branch. in-flight/24-x-y labels Feb 21, 2023
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@zcbenz @khalwa
fix: restoring X11 window should not remove previous maximize state (e…
ff39388 
…lectron#37346)
@trop trop bot added merged/22-x-y PR was merged to the "22-x-y" branch. and removed in-flight/22-x-y labels Feb 23, 2023
gecko19 pushed a commit to brightsign/electron that referenced this pull request Feb 28, 2023
@zcbenz @gecko19
fix: restoring X11 window should not remove previous maximize state (e…
4ded4b5 
…lectron#37346)
gecko19 pushed a commit to brightsign/electron that referenced this pull request Mar 15, 2023
@zcbenz @gecko19
fix: restoring X11 window should not remove previous maximize state (e…
29596fd 
…lectron#37346)
gecko19 pushed a commit to brightsign/electron that referenced this pull request Mar 15, 2023
@zcbenz @gecko19
fix: restoring X11 window should not remove previous maximize state (e…
6cefc60 
…lectron#37346)
@commit-lint commit-lint bot mentioned this pull request May 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dizopizo Dizopizo Dizopizo left review comments

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
merged/22-x-y PR was merged to the "22-x-y" branch. merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: On Linux window is not maximized when restored
4 participants
@zcbenz @deepak1556 @codebytere @Dizopizo