You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
autoUpdater's docs say that quitAndInstall should only be called after 'update-downloaded' has been emitted, and if it is called before that is emitted, the app will quit but not reopen.
For both these reasons, autoUpdater should emit an error (and not proceed to quit) if quitAndInstall is called without an update to apply.
The text was updated successfully, but these errors were encountered:
Oh for sure. I just think that the auto-updater itself should enforce that restriction since seeing an error is better UX than seeing the app quit and it not come back.
(One simple though perhaps not-totally-correct way to fix this would be to have the auto-updater itself listen for 'update-downloaded' and only allow quitAndInstall to be called thereafter—is that what you were suggesting?)
autoUpdater
's docs say thatquitAndInstall
should only be called after'update-downloaded'
has been emitted, and if it is called before that is emitted, the app will quit but not reopen.For both these reasons,
autoUpdater
should emit an error (and not proceed to quit) ifquitAndInstall
is called without an update to apply.The text was updated successfully, but these errors were encountered: