Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wayland csd on gnome are broke for 25.x and newer. #38786

Closed
3 tasks done
frosth555 opened this issue Jun 14, 2023 · 5 comments · Fixed by #39003
Closed
3 tasks done

wayland csd on gnome are broke for 25.x and newer. #38786

frosth555 opened this issue Jun 14, 2023 · 5 comments · Fixed by #39003
Labels
25-x-y bug 🪲 platform/linux

Comments

@frosth555
Copy link

Preflight Checklist

Electron Version

25.1

What operating system are you using?

Other Linux

Operating System Version

Arch Linux / 6.3.7-zen1-1-zen

What arch are you using?

x64

Last Known Working Electron version

24.5

Expected Behavior

$ electron24 --ozone-platform-hint=auto --enable-features=UseOzonePlatform,WaylandWindowDecorations
Zrzut ekranu z 2023-06-14 15-12-55

Actual Behavior

$ electron25 --ozone-platform-hint=auto --enable-features=UseOzonePlatform,WaylandWindowDecorations
Zrzut ekranu z 2023-06-14 15-14-58

Testcase Gist URL

No response

Additional Information

any electron version newer than 24 (25/alpha-26/nightbuild-27) are broken
@heftig
Copy link

heftig commented Jun 14, 2023 •
edited

Hi-DPI support seems to have been lost in 25 as well, which seems related. The windows have scale 1 even when the monitor has scale 2, thus get upscaled by gnome-shell.

PS: Never mind, the proper scale can be restored with --disable-features=WaylandFractionalScaleV1 (chromium issue 1356014), but this doesn't restore the title bar buttons.

@dtcooper
Copy link

dtcooper commented Jun 28, 2023 •
edited

Confirming the lack of title bar buttons on Wayland.

I start my Electron app with --ozone-platform=wayland --enable-features=WaylandWindowDecorations and don't get the close, minimize and maximize buttons.

Using GNOME 44.2 with Wayland. Rolling back to version 24 (24.6.1 as of this writing) is a workaround for now.

dtcooper added a commit to dtcooper/tomato that referenced this issue Jun 28, 2023
@dtcooper
Bump deps, pin electron, re: close button bug
35055c4 
Bug: electron/electron#38786
This was referenced Jun 29, 2023
Closed
Closed
Closed
@orowith2os
Copy link

I've been getting this with Element (im.riot.Riot) too. No buttons, everything else works.

aiddya added a commit to aiddya/electron that referenced this issue Jul 6, 2023
@aiddya
fix: remove types from GTK CSS selectors
f21907d 
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.

Fixes electron#38786
@aiddya aiddya mentioned this issue Jul 6, 2023
Merged
3 tasks
aiddya added a commit to aiddya/electron that referenced this issue Jul 10, 2023
@aiddya
fix: remove types from GTK CSS selectors
00c47d0 
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.

Fixes electron#38786
codebytere pushed a commit that referenced this issue Jul 10, 2023
@aiddya
fix: remove types from GTK CSS selectors (#39003)
3e31520 
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.

Fixes #38786

Co-authored-by: Athul Iddya <athul@iddya.com>
trop bot added a commit that referenced this issue Jul 10, 2023
@trop @aiddya
fix: remove types from GTK CSS selectors
e19dc6d 
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.

Fixes #38786

Co-authored-by: Athul Iddya <athul@iddya.com>
trop bot added a commit that referenced this issue Jul 10, 2023
@trop @aiddya
fix: remove types from GTK CSS selectors
85bc7d6 
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.

Fixes #38786

Co-authored-by: Athul Iddya <athul@iddya.com>
zcbenz pushed a commit that referenced this issue Jul 11, 2023
@trop @aiddya
fix: remove types from GTK CSS selectors (#39044)
5305596 
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.

Fixes #38786

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Athul Iddya <athul@iddya.com>
codebytere pushed a commit that referenced this issue Jul 11, 2023
@trop @aiddya
fix: remove types from GTK CSS selectors (#39045)
d463bf9 
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.

Fixes #38786

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Athul Iddya <athul@iddya.com>
@enigma9o7 enigma9o7 mentioned this issue Jul 12, 2023
Closed
@maymage maymage mentioned this issue Jul 13, 2023
Closed
2 tasks
@Midar
Copy link

Midar commented Jul 19, 2023

Can confirm that all Electron apps look really blurry and without a titlebar. Adding --disable-features=WaylandFractionalScaleV1 does not fix the blurriness for me.

@DeedleFake DeedleFake mentioned this issue Jul 20, 2023
Closed
@major-mayer major-mayer mentioned this issue Jul 23, 2023
Closed
2 tasks
@frosth555 frosth555 mentioned this issue Jul 25, 2023
Closed
3 tasks
@PRGWITHSTYLE
Copy link

I'm still seeing this issue on a Fedora based Linux distro using wayland

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this issue Dec 11, 2023
@aiddya
fix: remove types from GTK CSS selectors (electron#39003)
71d5c6c 
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.

Fixes electron#38786

Co-authored-by: Athul Iddya <athul@iddya.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
25-x-y bug 🪲 platform/linux
Projects
No open projects
25-x-y
Status: Unsorted Items
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove types from GTK CSS selectors aiddya/electron
7 participants
@heftig @Midar @dtcooper @deermichel @frosth555 @PRGWITHSTYLE @orowith2os