Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: error callback on print #38975

Closed
3 tasks done
AkhmedovSH opened this issue Jul 3, 2023 · 2 comments · Fixed by #38976
Closed
3 tasks done

[Bug]: error callback on print #38975

AkhmedovSH opened this issue Jul 3, 2023 · 2 comments · Fixed by #38976
Assignees
Labels
blocked/need-repro Needs a test case to reproduce the bug bug 🪲

Comments

@AkhmedovSH
Copy link

Preflight Checklist

Electron Version

24.1.1

What operating system are you using?

Windows

Operating System Version

Windows 10

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

I have no paper in my printer and when I want print it document stay in queue
and electron
window.contents.print(options, (success, errorType) => {
console.log(success)
console.log(errorType)
})

errorType is empty and success return true but i am not printed anything because no paper
if my document not printing success have to return false and if my document in a queue errorType have to return some information about it

Actual Behavior

success true
and no errorType

Testcase Gist URL

No response

Additional Information

No response

@AkhmedovSH
Copy link
Author

@codebytere sorry, any news about this issue

@codebytere codebytere added the blocked/need-repro Needs a test case to reproduce the bug label Jul 10, 2023
@electron electron deleted a comment from github-actions bot Jul 10, 2023
@codebytere
Copy link
Member

codebytere commented Jul 10, 2023

if my document not printing success have to return false and if my document in a queue errorType have to return some information about it

The method returns true if the document was successfully sent to the printer. Issues like the printer having no paper are not relevant to whether it returns true. This is also how Chrome works and how this API has always functioned.

@codebytere codebytere closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/need-repro Needs a test case to reproduce the bug bug 🪲
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants