fix: printing optional access crash on Windows

[codebytere]

Description of Change

Closes #38975
Closes #38944

Refs CL:4412367 and CL:4409898

Fixes an issue where printing on Windows could trigger a RAW: Bad optional access crash. This happened as a result of cloning job_settings and calling std::move on it in the same function call, which interestingly works just fine on macOS but doesn't on Windows.

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixes an issue where printing on Windows could trigger a crash.

[zcbenz]

I think I understand the crash now, the old code was basically doing this:

SetSettings(job_settings.Clone(), std::move(job_settings));

and the result would depend on the order of parameter evaluation: for environments that evaluate job_settings.Clone() first, things work expected; but for environments that evaluate std::move(job_settings) first, the cloned value would be null.

So this PR does correctly fix the crash, but there should be some comments added on why it works.

[release-clerk]

Release Notes Persisted

Fixes an issue where printing on Windows could trigger a crash.

[trop]

I was unable to backport this PR to "25-x-y" cleanly;
you will need to perform this backport manually.

[trop]

I have automatically backported this PR to "26-x-y", please check out #39039

[trop]

@codebytere has manually backported this PR to "25-x-y", please check out #39095