Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add gin_helper::Dictionary::CreateEmpty() helper #39547

Merged
merged 1 commit into from
Aug 21, 2023
Merged

refactor: add gin_helper::Dictionary::CreateEmpty() helper #39547

merged 1 commit into from
Aug 21, 2023

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Aug 17, 2023 •
edited

It allows using

auto dict = gin_helper::Dictionary::CreateEmpty(isolate);

which is IMO more readable than

gin_helper::Dictionary dict = gin::Dictionary::CreateEmpty(isolate);

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 17, 2023
@miniak miniak self-assigned this Aug 17, 2023
@miniak miniak added semver/patch backwards-compatible bug fixes no-backport labels Aug 17, 2023
@miniak miniak marked this pull request as ready for review August 17, 2023 00:58
@miniak miniak requested a review from zcbenz August 17, 2023 01:00
@deepak1556
Copy link
Member

Can you rebase on latest main, linux failures are addressed in #39481

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 18, 2023
@miniak
Copy link
Contributor Author

miniak commented Aug 19, 2023

@deepak1556 rebased

@deepak1556 deepak1556 merged commit 0919008 into main Aug 21, 2023
14 checks passed
@deepak1556 deepak1556 deleted the miniak/gin-helper-auto branch August 21, 2023 01:43
@release-clerk
Copy link

release-clerk bot commented Aug 21, 2023

No Release Notes

win32ss pushed a commit to win32ss/supermium-electron that referenced this pull request Sep 24, 2023
@miniak
refactor: add gin_helper::Dictionary::CreateEmpty() helper (electron#…
9df7aaa 
…39547)
@miniak miniak mentioned this pull request Oct 9, 2023
Merged
@commit-lint commit-lint bot mentioned this pull request Nov 13, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@miniak
refactor: add gin_helper::Dictionary::CreateEmpty() helper (electron#…
71266dd 
…39547)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees

@miniak miniak

Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniak @deepak1556 @zcbenz