revert: promise resolved too early when browser initiates in-page navigation #39481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igation This reverts commit a0effaf.
dsanders11
approved these changes
Aug 12, 2023
zcbenz
approved these changes
Aug 13, 2023
|
The failing tests are not related to this PR. |
|
No Release Notes |
5 tasks
win32ss
pushed a commit
to win32ss/supermium-electron
that referenced
this pull request
Sep 24, 2023
…igation (electron#39481) This reverts commit a0effaf.
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
…igation (electron#39481) This reverts commit a0effaf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #39260
This PR is causing Linux failures across branches:
Notes: none.