Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Invalid PlatformChannel receive right when closing better-sqlite3 database (Possible regression) #39600

Closed
3 tasks done
linonetwo opened this issue Aug 21, 2023 · 5 comments
Labels
26-x-y bug 🪲 crash 💥 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ stale

Comments

@linonetwo
Copy link

linonetwo commented Aug 21, 2023

Preflight Checklist

Electron Version

26.0.0 electron v26.0.0-beta.2

What operating system are you using?

macOS

Operating System Version

13.5 (22G74)

What arch are you using?

x64

Last Known Working Electron version

25.6.0 electron v26.0.0-beta.1

Expected Behavior

No crush or error.

Actual Behavior

Immeadately crush with this output in the console:

[69364:0822/003532.451897:ERROR:child_thread_impl.cc(235)] Invalid PlatformChannel receive right

Testcase Gist URL

https://gist.github.com/linonetwo/aa3d3ad829a3497af6bc1e269c2a613e

I bysect in fiddle to make sure bug happen between electron v26.0.0-beta.1 ~ v26.0.0-beta.2

Additional Information

Electron fiddle seem to have problem installing better-sqlite3 electron/fiddle#1444

So in the gist I use

nativeBinding: '/Users/linonetwo/Desktop/repo/TiddlyGit-Desktop/node_modules/better-sqlite3/build/Release/better_sqlite3.node'

You may need to install better-sqlite3 somewhere and get the file path like this, and modify this line, sorry!

Otherwise it will error:

(node:69993) UnhandledPromiseRejectionWarning: Error: The module '/private/var/folders/t3/0jyr287x3rd2m0b6ml8w4f2c0000gn/T/electron-fiddle-65967-ge4Iih4ZET7a/node_modules/better-sqlite3/build/Release/better_sqlite3.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 115. This version of Node.js requires
NODE_MODULE_VERSION 116. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).
@linonetwo linonetwo changed the title [Bug]: [Bug]: Invalid PlatformChannel receive right when closing better-sqlite3 database (Possible regression) Aug 21, 2023
linonetwo added a commit to tiddly-gittly/TidGi-Desktop that referenced this issue Aug 21, 2023
@jkleinsc jkleinsc added has-repro-gist Issue can be reproduced with code at https://gist.github.com/ 26-x-y labels Aug 21, 2023
@codebytere
Copy link
Member

We can probably safely say it's caused by #38826 then. I'll see what i can do.

@Ridhwan889

This comment was marked as abuse.

@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@linonetwo
Copy link
Author

@ZIMkaRU Hi, seems you have a workaround for this? Does it work? If it worked, I will close this.

@ZIMkaRU
Copy link

ZIMkaRU commented Nov 29, 2023

Hi @linonetwo
no specific solution here
If I'm not mistaken, there was a problem with running the driver on version v26
at that time I downgraded the version to v25 and everything works, now we use v27 and everything is fine too
we had to skip version 26
as for me, it can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26-x-y bug 🪲 crash 💥 has-repro-gist Issue can be reproduced with code at https://gist.github.com/ stale
Projects
No open projects
Status: 👀 Unsorted Items
Development

No branches or pull requests

5 participants