Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix some string union typings #40180

Merged
merged 1 commit into from Oct 13, 2023
Merged

docs: fix some string union typings #40180

merged 1 commit into from Oct 13, 2023

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Oct 11, 2023 •
edited

Description of Change

Another instance of #38339. electron/docs-parser doesn't like double quotes, or the word 'either'. See the Artifact Comparison check output for difference.

Checklist

  • PR description included and stakeholders cc'd

Release Notes

Notes: none

@dsanders11 dsanders11 added target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Oct 11, 2023
@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Oct 11, 2023
@dsanders11 dsanders11 marked this pull request as ready for review October 11, 2023 23:11
@codebytere
Copy link
Member

@dsanders11 we should probably correct this upstream too so it can handle double quotes 🤔

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 12, 2023
@dsanders11
Copy link
Member Author

@codebytere, opened an upstream issue: electron/docs-parser#97

@codebytere codebytere merged commit 5d6023a into main Oct 13, 2023
27 checks passed
@codebytere codebytere deleted the docs-fix-typings branch October 13, 2023 10:00
@release-clerk
Copy link

release-clerk bot commented Oct 13, 2023

No Release Notes

@trop trop bot mentioned this pull request Oct 13, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 13, 2023

I was unable to backport this PR to "27-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Oct 13, 2023

I was unable to backport this PR to "25-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/27-x-y and removed target/27-x-y PR should also be added to the "27-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels Oct 13, 2023
@trop
Copy link
Contributor

trop bot commented Oct 13, 2023

I was unable to backport this PR to "26-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Oct 13, 2023

I have automatically backported this PR to "28-x-y", please check out #40199

@trop trop bot added in-flight/28-x-y needs-manual-bp/26-x-y and removed target/26-x-y PR should also be added to the "26-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. labels Oct 13, 2023
@dsanders11 dsanders11 mentioned this pull request Oct 13, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 13, 2023

@dsanders11 has manually backported this PR to "27-x-y", please check out #40202

dsanders11 added a commit to dsanders11/electron that referenced this pull request Oct 13, 2023
@dsanders11
docs: fix some string union typings (electron#40180)
97cd6b7
@dsanders11 dsanders11 mentioned this pull request Oct 13, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 13, 2023

@dsanders11 has manually backported this PR to "26-x-y", please check out #40203

@dsanders11 dsanders11 mentioned this pull request Oct 13, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 13, 2023

@dsanders11 has manually backported this PR to "25-x-y", please check out #40204

@trop trop bot added in-flight/25-x-y merged/25-x-y PR was merged to the "25-x-y" branch. and removed needs-manual-bp/25-x-y in-flight/25-x-y labels Oct 13, 2023
zcbenz pushed a commit that referenced this pull request Oct 16, 2023
@dsanders11
docs: fix some string union typings (#40203)
ad34b4b 
docs: fix some string union typings (#40180)
@trop trop bot added merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. and removed in-flight/26-x-y in-flight/27-x-y in-flight/28-x-y labels Oct 16, 2023
felixrieseberg pushed a commit to felixrieseberg/electron that referenced this pull request Oct 25, 2023
@dsanders11 @felixrieseberg
docs: fix some string union typings (electron#40180)
70a9857
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@dsanders11
docs: fix some string union typings (electron#40180)
0311d40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
documentation 📓 merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsanders11 @codebytere @MarshallOfSound