test: fix Node.js color edge snapshot stack traces #40250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-forced-colors
branch
from
5eb2b1a
to
b292f30
Compare
codebytere
force-pushed
the
fix-forced-colors
branch
from
b292f30
to
af4943f
Compare
jkleinsc
approved these changes
Oct 18, 2023
This was referenced Oct 18, 2023
|
No Release Notes |
|
I was unable to backport this PR to "27-x-y" cleanly; |
trop
bot
removed
the
target/27-x-y
|
I was unable to backport this PR to "28-x-y" cleanly; |
trop
bot
added
needs-manual-bp/27-x-y
needs-manual-bp/28-x-y
and removed
target/28-x-y
felixrieseberg
pushed a commit
to felixrieseberg/electron
that referenced
this pull request
Oct 25, 2023
codebytere
added
no-backport
and removed
needs-manual-bp/27-x-y
needs-manual-bp/28-x-y
labels
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes an ongoing issue with
forced_colorsnapshot matching failing whenever we adjust asar-related code in Node.js. Pulls in an upstream PR from Node.js designed to address the same issue.I've also opened an upstream PR to v18 which will allow us to remove this patch.
Checklist
npm testpassesRelease Notes
Notes: none