Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly track receiver for methods called via ctx bridge #40262

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Oct 18, 2023

Backport of #39978

See that PR for details.

Notes: Functions called over the contextBridge are now called with the expected receiver (this)

trop bot and others added 2 commits October 18, 2023 14:21
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested a review from MarshallOfSound October 18, 2023 14:22
@trop trop bot added 27-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 18, 2023
@codebytere
Copy link
Member

Known failure - see #40250

@codebytere codebytere merged commit 64318df into 27-x-y Oct 18, 2023
16 of 17 checks passed
@codebytere codebytere deleted the trop/27-x-y-bp-fix-correctly-track-receiver-for-methods-called-via-ctx-bridge-1697638916019 branch October 18, 2023 19:38
@release-clerk
Copy link

release-clerk bot commented Oct 18, 2023

Release Notes Persisted

Functions called over the contextBridge are now called with the expected receiver (this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant