Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: App crashes when unloading webview before it finished rendering since Electron 26.1.0 #40391

Closed
3 tasks done
wartab opened this issue Oct 31, 2023 · 3 comments · Fixed by #40400
Closed
3 tasks done
Assignees

Comments

@wartab
Copy link

wartab commented Oct 31, 2023

Preflight Checklist

Electron Version

27.0.2

What operating system are you using?

Windows

Operating System Version

Windows 10/11

What arch are you using?

x64

Last Known Working Electron version

16.0.0

Expected Behavior

The application should just move on and not crash.

Actual Behavior

The application closes without any error message shown or logged.

Testcase Gist URL

https://github.com/wartab/electron-bug

Additional Information

I previously reported this here, but another customer of ours had this issue happen on a fast PC and I could reproduce it on mine as well.
#40288

I can't reproduce it in Electron Fiddle, but the following repository reproduces the issue.

It attempts to load a webview with inline HTML in the src attribute. That HTML is > 3 MB large with inline images. Electron never manages to render this webview, but when unloading the webview, the app crashes.

Simply removing the webview with removeChild() didn't crash the application, so my minimum reproduction is a bit closer to what we actually do. It is in an Angular application. The reproduction contains the app already built in dist-angular.

To reproduce:
npm i
Optionally: ng build --base-href .
npm run-script build-electron

@wartab
Copy link
Author

wartab commented Oct 31, 2023

And I confirm 100% that the crash does not happen in 26.0.0, but does in 26.1.0!

@codebytere codebytere added blocked/need-repro Needs a test case to reproduce the bug and removed blocked/need-repro Needs a test case to reproduce the bug labels Oct 31, 2023
@electron electron deleted a comment from electron-issue-triage bot Oct 31, 2023
@codebytere codebytere added the blocked/need-repro Needs a test case to reproduce the bug label Oct 31, 2023
@codebytere codebytere self-assigned this Nov 1, 2023
@codebytere
Copy link
Member

@wartab figured out how to repro it - should have a PR up soon.

@codebytere codebytere removed the blocked/need-repro Needs a test case to reproduce the bug label Nov 1, 2023
@electron electron deleted a comment from electron-issue-triage bot Nov 1, 2023
@wartab
Copy link
Author

wartab commented Nov 1, 2023

Ah thanks a lot, literally started trying to make it work without Angular less than 10 minutes ago. Trying to find what caused the bug had already taken me many hours of debugging on the slowest computer ever. 😆
If you have a simple reproduction, I'd be curious to know why just deleting the element from the DOM wasn't sufficient to cause the crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 👀 Unsorted Items
Status: 👍 Does Not Block Stable
Status: 🛠️ Fixed for Next Release
Development

Successfully merging a pull request may close this issue.

2 participants