fix: crash when unloading some WebViews #40400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
ckerr
reviewed
Nov 1, 2023
ckerr
approved these changes
Nov 2, 2023
jkleinsc
approved these changes
Nov 3, 2023
|
Release Notes Persisted
|
This was referenced Nov 3, 2023
|
I have automatically backported this PR to "26-x-y", please check out #40443 |
trop
bot
added
in-flight/26-x-y
and removed
target/26-x-y
|
I have automatically backported this PR to "27-x-y", please check out #40444 |
|
I have automatically backported this PR to "28-x-y", please check out #40445 |
trop
bot
added
in-flight/27-x-y
in-flight/28-x-y
merged/28-x-y
trop
bot
added
merged/26-x-y
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #40391.
Refs #39428.
Fixes an issue where WebViews could sometimes crash on unload as a result of recent changes made to WebContentsZoomController. Previously, we called back to observers in several fewer places, and when I updated the ZoomController impl, I didn't pull in changes to
guest_view_base.ccwhich handle potential looping as a result of these events by early-exiting if the new zoom level isn't different.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where WebViews could sometimes crash on unload.