Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Ask for help to support 64k PAGESIZE on aarch64 #40605

Closed
3 tasks done
Hailiang1986 opened this issue Nov 23, 2023 · 1 comment
Closed
3 tasks done

Comments

@Hailiang1986
Copy link

Preflight Checklist

Problem Description

We found that electron is not support 64K pagesize on aarch64, there is an issue talking about this problem which has been closed. #25387.
We really need electron to support 64K pagesize in our project, so we tried to fix this problem by ourselves, but we have been stuck in compiling electron for long time. @:(
We just follow the build instructions in https://www.electronjs.org/docs/latest/development/build-instructions-gn, but always failed in the step 'gclient sync -f', it seems to download all the packages need by compiling electron.
So we come here for help, hoping to get assistance from the experts:

  1. Is there any plan to support 64K PAGESIZE for electron?
  2. Or Are there any container images with pre-built development environments that can be shared? Or are there any other development environments available that can assist with quickly building Electron?
  3. Regarding the support for 64k pagesize in Electron, is it sufficient to modify Electron itself to support this, or do some components of Chromium, on which Electron depends, need to be modified as well to support 64k?

Proposed Solution

If we can resolve the Electron build issue, we are willing to submit a patch to the community to fix the support for 64K pagesize.

Alternatives Considered

NA

Additional Information

No response

@codebytere
Copy link
Member

@Hailiang1986 see #25387 (comment) - Chromium doesn't support this, making it harder for us to do so and indicating that we'd likely need to patch in order to enable your use case. As of now, that's not something we're likely to do, both for impact and maintenance burden reasons.

With regard to your build issue - you should use https://github.com/electron/build-tools - it wraps over our build toolchain and makes things much more manageable :)

@codebytere codebytere closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants