Convert from CoffeeScript to JavaScript #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsawicki
changed the title
|
woop to this 👍 |
|
👍 |
|
Keep going' 👍 😎 |
kevinsawicki
force-pushed
the
coffee-to-js
branch
from
045bc04
to
b547a38
Compare
|
👍 |
zcbenz
added a commit
that referenced
this pull request
Jan 13, 2016
[WIP] Convert from CoffeeScript to JavaScript
|
I'm so happy for this change 😄 |
kevinsawicki
changed the title
Merged
This was referenced Jan 15, 2016
Merged
This was referenced Mar 16, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrates all of the CoffeeScript source files to JavaScript.
📈 CoffeeScript was great when this project started, but many of the best parts of it are now in ES6 and available out of the box in Electron. See this blog post for some examples.
☕ The JavaScript files in this pull request were generated using CoffeeScript
1.10.0. A second pass will be made in a follow-up pull request to reformat the JavaScript and draft a new styleguide. This is done to minimally disrupt any open or soon to be opened pull requests that may touch the existing.coffeefiles.📝 The comments have been retained by first migrating all the
#comments to###which were then compiled to/* */style comments in the JavaScript.🎯 The goal is to make Electron as approachable as possible and also to have its source code reflect the capabilities of the V8 version being used.
Changes to be made in subsequent pull requests
returnstatementsextend,slice, andindexOfletandconstappropriately=>) functions