Destructuring assignment #4872
Merged
Destructuring assignment #4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsawicki
force-pushed
the
destructured-assignment
branch
from
db3ac07
to
b784ea7
Compare
| @@ -582,8 +581,7 @@ | |||
| }; | |||
| mkdirSync = fs.mkdirSync; | |||
| fs.mkdirSync = function(p, mode) { | |||
| var filePath, isAsar, ref; | |||
| ref = splitPath(p), isAsar = ref[0], filePath = ref[2]; | |||
| const [isAsar, , filePath] = splitPath(p); | |||
There was a problem hiding this comment.
I didn't know const [isAsar, , filePath] = splitPath(p); would work. That's cool.
I just tried it in the node (5.8) repl, but destructuring assignment is not ready yet. Is there an electron repl? That would be cool. I tried it in Mancy too, but no 🎲 because even though it's an electron app I think it's just using node under the hood.
There was a problem hiding this comment.
Yeah, I saw this in the mdn docs and was pretty impressed that it is supported.
Yeah, not sure about a repl, there must be one out there.
|
🐑 |
kevinsawicki
force-pushed
the
destructured-assignment
branch
from
b784ea7
to
2d32956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use destructuring assignment available in Chrome 49 in the places it was previously being when CoffeeScript was used.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment
Refs #4065