fix: update osk patch to fix more corner cases #41149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
This is a follow up to #35921 that, it fixes more corner cases that on-screen-keyboard does not hide for webviews. This change has been applied in Teams for quite a while and should be reliable enough to introduce to Electron. Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
5 tasks
trop
bot
added
29-x-y
backport
codebytere
approved these changes
Jan 29, 2024
codebytere
deleted the
trop/29-x-y-bp-fix-update-osk-patch-to-fix-more-corner-cases-1706492595647
branch
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #41131
See that PR for details.
Notes: Fix on-screen-keyboard not hiding for webviews under some cases.