fix: update osk patch to fix more corner cases #41131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
added
semver/patch
This is a follow up to #35921 that, it fixes more corner cases that on-screen-keyboard does not hide for webviews. This change has been applied in Teams for quite a while and should be reliable enough to introduce to Electron.
ckerr
approved these changes
Jan 26, 2024
codebytere
approved these changes
Jan 28, 2024
|
Release Notes Persisted
|
|
I was unable to backport this PR to "27-x-y" cleanly; |
trop
bot
removed
the
target/27-x-y
|
I was unable to backport this PR to "28-x-y" cleanly; |
trop
bot
added
needs-manual-bp/27-x-y
needs-manual-bp/28-x-y
and removed
target/28-x-y
|
I have automatically backported this PR to "29-x-y", please check out #41149 |
trop
bot
added
in-flight/29-x-y
and removed
target/29-x-y
trop
bot
added
merged/29-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a follow up to #35921 that, it fixes more corner cases that on-screen-keyboard does not hide for webviews.
This change has been applied in Teams for quite a while and should be reliable enough to introduce to Electron.
Checklist
npm testpassesRelease Notes
Notes: Fix on-screen-keyboard not hiding for webviews under some cases.