Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: WebviewTag.webpreferences has wrong type #42248

Closed
3 tasks done
Sabrish-Krish opened this issue May 22, 2024 · 1 comment · Fixed by #42275
Closed
3 tasks done

[Bug]: WebviewTag.webpreferences has wrong type #42248

Sabrish-Krish opened this issue May 22, 2024 · 1 comment · Fixed by #42275
Labels
30-x-y bug 🪲 component/typescript status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@Sabrish-Krish
Copy link

Sabrish-Krish commented May 22, 2024

Preflight Checklist

Electron Version

30.0.6

What operating system are you using?

macOS

Operating System Version

Sonoma 14.4.1

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

29.4.0

Expected Behavior

Can assign "contextIsolation=false, nodeintegration=true" and other valid strings to WebviewTag.webpreferences. The type of WebviewTag.webpreferences should be string.

Actual Behavior

error TS2322: Type '"contextIsolation=false"' is not assignable to type '"transparent"'

WebviewTag.webpreferences has type 'transparent'.

Testcase Gist URL

No response

Additional Information

@clavin clavin changed the title [Bug]: error TS2322: Type '"contextIsolation=false"' is not assignable to type '"transparent"'. [Bug]: WebviewTag.webpreferences has wrong type May 22, 2024
@clavin clavin added component/typescript status/confirmed A maintainer reproduced the bug or agreed with the feature labels May 22, 2024
@Sabrish-Krish
Copy link
Author

Thanks for the fix. But post this we were facing an issue post electron upgrade.

Error:
/node_modules/electron/dist/Electron.app/Contents/MacOS/Electron exited with signal SIGTRAP
[91253:0529/192908.067019:ERROR:shared_memory_switch.cc(244)] Mach rendezvous failed, terminating process (parent died?)

Because of this our application is getting crashed frequently during testing. We havent faced such errors in previous versions. Attaching the error trace as well

Task trace:
0 Electron Framework 0x000000010db4acfc std::process::id::h056ebf195753a258 + 5891236
1 Electron Framework 0x000000010d88fdf4 std::process::id::h056ebf195753a258 + 3028380

Stack trace:
0 Electron Framework 0x000000010d5b88c8 std::process::id::h056ebf195753a258 + 49264
1 Electron Framework 0x000000010d5ad7cc std::process::id::h056ebf195753a258 + 3956
2 Electron Framework 0x000000010d5bbb6c std::process::id::h056ebf195753a258 + 62228
3 Electron Framework 0x000000010a3341a4 v8::CpuProfileNode::GetNodeId() const + 40560
4 Electron Framework 0x000000010a33208c v8::CpuProfileNode::GetNodeId() const + 32088
5 Electron Framework 0x000000010a2cc16c v8::CpuProfileNode::GetDeoptInfos() const + 36068
6 Electron Framework 0x000000010a331eec v8::CpuProfileNode::GetNodeId() const + 31672
7 Electron Framework 0x000000010a27d698 v8::ValueSerializer::Delegate::HasCustomHostObject(v8::Isolate*) + 79120
8 Electron Framework 0x000000010a27df54 v8::ValueSerializer::Delegate::HasCustomHostObject(v8::Isolate*) + 81356
9 Electron Framework 0x000000010a3f3c9c v8::CodeEvent::GetScriptName() + 230340
10 Electron Framework 0x000000010a3f410c v8::CodeEvent::GetScriptName() + 231476
11 Electron Framework 0x000000010a3f4040 v8::CodeEvent::GetScriptName() + 231272
12 Electron Framework 0x000000010a3f3ebc v8::CodeEvent::GetScriptName() + 230884
13 ??? 0x0000000157e10530 0x0 + 5769332016
14 ??? 0x00000001500f5044 0x0 + 5638148164
15 ??? 0x00000001500f60c4 0x0 + 5638152388
16 ??? 0x00000001500e9814 0x0 + 5638101012
17 ??? 0x0000000150119dd4 0x0 + 5638299092
18 ??? 0x00000001500e9814 0x0 + 5638101012
19 ??? 0x0000000157e0b6a8 0x0 + 5769311912
20 ??? 0x0000000157e0b398 0x0 + 5769311128
21 Electron Framework 0x000000010b57939c v8::Unwinder::PCIsInV8(unsigned long, v8::MemoryRange const*, void*) + 716
22 Electron Framework 0x000000010b47b480 v8::Function::Call(v8::Localv8::Context, v8::Localv8::Value, int, v8::Localv8::Value) + 384
23 Electron Framework 0x0000000110edc9c0 node::CallbackScope::~CallbackScope() + 1556
24 Electron Framework 0x0000000110edce08 node::MakeCallback(v8::Isolate
, v8::Localv8::Object, v8::Localv8::Function, int, v8::Localv8::Value, node::async_context) + 264
25 Electron Framework 0x000000010a3f5444 v8::CodeEvent::GetScriptName() + 236396
26 Electron Framework 0x000000010a31df54 v8::ValueSerializer::Delegate::GetWasmModuleTransferId(v8::Isolate
, v8::Localv8::WasmModuleObject) + 114092
27 Electron Framework 0x000000010a3061d4 v8::ValueSerializer::Delegate::GetWasmModuleTransferId(v8::Isolate*, v8::Localv8::WasmModuleObject) + 16428
28 Electron Framework 0x000000010a306a84 v8::ValueSerializer::Delegate::GetWasmModuleTransferId(v8::Isolate*, v8::Localv8::WasmModuleObject) + 18652
29 Electron Framework 0x000000010a342150 v8::BackingStore::MaxByteLength() const + 5508
30 Electron Framework 0x000000010d31affc node::GetMultiIsolatePlatform(node::IsolateData*) + 7256940
31 Electron Framework 0x000000010a342298 v8::BackingStore::MaxByteLength() const + 5836
32 Electron Framework 0x000000010d86f988 std::process::id::h056ebf195753a258 + 2896176
33 Electron Framework 0x000000010d8743ac std::process::id::h056ebf195753a258 + 2915156
34 Electron Framework 0x000000010d871574 std::process::id::h056ebf195753a258 + 2903324
35 Electron Framework 0x000000010db4da38 std::process::id::h056ebf195753a258 + 5902816
36 Electron Framework 0x000000010db4e1b8 std::process::id::h056ebf195753a258 + 5904736
37 Electron Framework 0x000000010d55d2b8 std::sys::pal::unix::os::errno::h12fdde1c2329795a + 279504
38 Electron Framework 0x000000010d577798 std::sys::pal::unix::os::errno::h12fdde1c2329795a + 387248
39 Electron Framework 0x000000010d577da8 std::sys::pal::unix::os::errno::h12fdde1c2329795a + 388800
40 Electron Framework 0x000000010d5c1cd0 std::process::id::h056ebf195753a258 + 87160
41 Electron Framework 0x000000010a1cd600 Electron Framework + 2004480
42 Electron Framework 0x000000010d5c0e98 std::process::id::h056ebf195753a258 + 83520
43 CoreFoundation 0x000000018e579eb0 CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION + 28
44 CoreFoundation 0x000000018e579e44 __CFRunLoopDoSource0 + 176
45 CoreFoundation 0x000000018e579bb4 __CFRunLoopDoSources0 + 244
46 CoreFoundation 0x000000018e5787a0 __CFRunLoopRun + 828
47 CoreFoundation 0x000000018e577e0c CFRunLoopRunSpecific + 608
48 HIToolbox 0x0000000198d13000 RunCurrentEventLoopInMode + 292
49 HIToolbox 0x0000000198d12e3c ReceiveNextEventCommon + 648
50 HIToolbox 0x0000000198d12b94 _BlockUntilNextEventMatchingListInModeWithFilter + 76
51 AppKit 0x0000000191dd0970 _DPSNextEvent + 660
52 AppKit 0x00000001925c2dec -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 700
53 AppKit 0x0000000191dc3cb8 -[NSApplication run] + 476
54 Electron Framework 0x000000010d5c28ec std::process::id::h056ebf195753a258 + 90260
55 Electron Framework 0x000000010d5c085c std::process::id::h056ebf195753a258 + 81924
56 Electron Framework 0x000000010d578410 std::sys::pal::unix::os::errno::h12fdde1c2329795a + 390440
57 Electron Framework 0x000000010d543740 std::sys::pal::unix::os::errno::h12fdde1c2329795a + 174168
58 Electron Framework 0x000000010c71361c v8::internal::compiler::CompilationDependencies::FieldTypeDependencyOffTheRecord(v8::internal::compiler::MapRef, v8::internal::compiler::MapRef, v8::internal::InternalIndex, v8::internal::compiler::ObjectRef) const + 9098976
59 Electron Framework 0x000000010c71509c v8::internal::compiler::CompilationDependencies::FieldTypeDependencyOffTheRecord(v8::internal::compiler::MapRef, v8::internal::compiler::MapRef, v8::internal::InternalIndex, v8::internal::compiler::ObjectRef) const + 9105760
60 Electron Framework 0x000000010c710f50
v8::internal::compiler::CompilationDependencies::FieldTypeDependencyOffTheRecord(v8::internal::compiler::MapRef, v8::internal::compiler::MapRef, v8::internal::InternalIndex, v8::internal::compiler::ObjectRef) const + 9089044
61 Electron Framework 0x000000010a58e644 v8::CodeEvent::GetScriptLine() + 378780
62 Electron Framework 0x000000010a58f6a4 v8::CodeEvent::GetScriptLine() + 382972
63 Electron Framework 0x000000010a58f51c v8::CodeEvent::GetScriptLine() + 382580
64 Electron Framework 0x000000010a58de5c v8::CodeEvent::GetScriptLine() + 376756
65 Electron Framework 0x000000010a58e020 v8::CodeEvent::GetScriptLine() + 377208
66 Electron Framework 0x000000010a26851c ElectronMain + 180
67 dyld 0x000000018e1120e0 start + 2360

Kindly advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
30-x-y bug 🪲 component/typescript status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
No open projects
Status: 👀 Unsorted Items
Development

Successfully merging a pull request may close this issue.

2 participants