Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add systemPreferences module #5282

Merged
merged 8 commits into from
Apr 25, 2016
Merged

Add systemPreferences module #5282

merged 8 commits into from
Apr 25, 2016

Conversation

zcbenz
Copy link
Member

@zcbenz zcbenz commented Apr 25, 2016 •
edited

systemPreferences

Also deprecate the system preferences related APIs in app module.

Close #1861
Close #4954.

@zcbenz zcbenz mentioned this pull request Apr 25, 2016
Closed
@danhp
Copy link
Contributor

danhp commented Apr 25, 2016

Shouldn't the documentation for the platform-theme-changed event also be removed from the app doc?

@zcbenz
Copy link
Member Author

zcbenz commented Apr 25, 2016

@phamdaniel Good catch, thanks!

@zcbenz zcbenz merged commit 63d0704 into master Apr 25, 2016
@zcbenz zcbenz deleted the system-preferences branch April 25, 2016 23:21
@danhp danhp mentioned this pull request Apr 30, 2016
Merged
@MathijsvVelde MathijsvVelde mentioned this pull request May 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @danhp