You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks @bengotow for the y-offset, would it be possible to do a x-offset also? It may seem like an odd request but if you have a full-height sidebar menu then the sheet should be centered on the content pane. It's best understood with a screenshot (the dialog should not overlap the sidebar)...
Probably would have been easier if I identified this potential issue in #4679 (sorry!).
Perhaps the best backwards compatible way to introduce this functionality is to keep the existing API but also accept an object with x and y values:
I'm happy to have a go implementing this myself but I haven't hacked on the codebase before and since @bengotow implemented the original feature then perhaps he is better placed to add this functionality?
The text was updated successfully, but these errors were encountered:
Thanks @bengotow for the y-offset, would it be possible to do a x-offset also? It may seem like an odd request but if you have a full-height sidebar menu then the sheet should be centered on the content pane. It's best understood with a screenshot (the dialog should not overlap the sidebar)...
Probably would have been easier if I identified this potential issue in #4679 (sorry!).
Perhaps the best backwards compatible way to introduce this functionality is to keep the existing API but also accept an object with
x
andy
values:I'm happy to have a go implementing this myself but I haven't hacked on the codebase before and since @bengotow implemented the original feature then perhaps he is better placed to add this functionality?
The text was updated successfully, but these errors were encountered: